This revision now requires changes to proceed.
baymax added a comment.
baymax requested changes to this revision.
There seems to have been no activities on this Diff for the past 3 Months.
By policy, we are automatically moving it out of the `need-review` state.
Please, move it back t
pulkit added a comment.
Turned out I have an unsubmitted comment. Also, the codebase was recently
formatted, so these patches will need to be rebased.
https://www.mercurial-scm.org/pipermail/mercurial-devel/2019-October/134537.html
should help
INLINE COMMENTS
> pulkit wrote in cmdutil.py:3
taapas1128 updated this revision to Diff 16791.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6659?vs=16155&id=16791
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6659/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6659
AFFECTED FI
taapas1128 added a comment.
taapas1128 marked an inline comment as done.
@durin42 done.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6659/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6659
To: taapas1128, #hg-reviewers, durin42
Cc: pulkit,
This revision now requires changes to proceed.
durin42 added inline comments.
durin42 requested changes to this revision.
INLINE COMMENTS
> cmdutil.py:3497
> +
> +def updateopts(repo, graftstate, opts):
> +"""updates opts and nodes from graftstate in case graft
This function is still mutatin
taapas1128 added inline comments.
INLINE COMMENTS
> pulkit wrote in cmdutil.py:3495
> the function name is not correct with respect to what it does, maybe
> something like `getopts` or something. Also, we no longer update the `opts`,
> so we can drop that as argument and also need to update the
taapas1128 marked an inline comment as done.
taapas1128 updated this revision to Diff 16155.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6659?vs=16120&id=16155
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6659/new/
REVISION DETAIL
http
pulkit added inline comments.
INLINE COMMENTS
> cmdutil.py:3431
> +"""logic to execute graft once revs are generated"""
> +graftstate = statemod.cmdstate(repo, 'graftstate')
> +for pos, ctx in enumerate(repo.set("%ld", revs)):
let's initialize `graftstate` only where we need it.
> c
taapas1128 added a comment.
@martinvonz @durin42 Have a look I ve updated the patch.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6659/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6659
To: taapas1128, #hg-reviewers, durin42
Cc: durin42, ma
taapas1128 updated this revision to Diff 16120.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6659?vs=15987&id=16120
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6659/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6659
AFFECTED FI
This revision now requires changes to proceed.
durin42 added a comment.
durin42 requested changes to this revision.
I agree with Martin's request for changes here.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6659/new/
REVISION DETAIL
https://phab.
martinvonz added a comment.
I just found a comment I wrote a while ago and forgot to submit. Sorry.
INLINE COMMENTS
> cmdutil.py:3495-3508
> +def continuegraftstate(repo, graftstate, opts):
> +"""updates opts based on the interrupted graftstate once
> +'--continue' flag is called."""
taapas1128 edited the summary of this revision.
taapas1128 retitled this revision from "graft: split graft code to avoid
duplication" to "graft: split graft code into seperate functions".
taapas1128 updated this revision to Diff 15987.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https
13 matches
Mail list logo
