D6683: unshelve: unify logic around creating an unshelve changeset

2019-07-29 Thread navaneeth.suresh (Navaneeth Suresh)
Closed by commit rHGc9114885c14b: unshelve: unify logic around creating an unshelve changeset (authored by navaneeth.suresh). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6683: unshelve: unify logic around creating an unshelve changeset

2019-07-26 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16078. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6683?vs=16074=16078 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6683/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6683

D6683: unshelve: unify logic around creating an unshelve changeset

2019-07-26 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added inline comments. INLINE COMMENTS > pulkit wrote in shelve.py:812 > How about: > > Handles creation of unshelve commit and updating the shelve if it was > partially unshelved. > > If interactive is: > > * false: commit all the changes in working directory. >

D6683: unshelve: unify logic around creating an unshelve changeset

2019-07-26 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > shelve.py:812 > +Here, we return both the newnode which is created interactively and a > +bool to know whether the shelve is partly done or completely done. > """ How about: Handles creation of unshelve commit and updating the

D6683: unshelve: unify logic around creating an unshelve changeset

2019-07-26 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16074. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6683?vs=16038=16074 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6683/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6683

D6683: unshelve: unify logic around creating an unshelve changeset

2019-07-24 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added a comment. In D6683#97731 , @pulkit wrote: > This patch does following things: > > 1. unify logic around creating unshelvectx > 2. changes how date is set in iteractive mode > 3. handles stripping in interavtive

D6683: unshelve: unify logic around creating an unshelve changeset

2019-07-24 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh edited the summary of this revision. navaneeth.suresh retitled this revision from "unshelve: fixes on interactive mode" to "unshelve: unify logic around creating an unshelve changeset". navaneeth.suresh updated this revision to Diff 16038. REPOSITORY rHG Mercurial CHANGES