D6684: unshelve: modify --continue on interactive unshelve

2019-07-25 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added a comment. In D6684#97930 , @pulkit wrote: > Sorry for getting this and the parent patch split before, after the recent improvements, it looks like they should be folded into one. Cool. Changes from this patch is

D6684: unshelve: modify --continue on interactive unshelve

2019-07-25 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Sorry for getting this and the parent patch split before, after the recent improvements, it looks like they should be folded into one. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6684/new/ REVISION DETAIL

D6684: unshelve: modify --continue on interactive unshelve

2019-07-24 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh edited the summary of this revision. navaneeth.suresh updated this revision to Diff 16058. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6684?vs=16056=16058 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6684/new/ REVISION

D6684: unshelve: modify --continue on interactive unshelve

2019-07-24 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh edited the summary of this revision. navaneeth.suresh updated this revision to Diff 16056. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6684?vs=16037=16056 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6684/new/ REVISION

D6684: unshelve: modify --continue on interactive unshelve

2019-07-24 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added inline comments. INLINE COMMENTS > pulkit wrote in shelve.py:950 > Now I understand how this and the parent patches are arranged. > > Why don't be have all the logic related to interactive in `unshelvecontinue`, > including getting the name of the shelve we are

D6684: unshelve: modify --continue on interactive unshelve

2019-07-24 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > shelve.py:950 > elif continuef: > -return unshelvecontinue(ui, repo, state, opts) > -elif len(shelved) > 1: Now I understand how this and the parent patches are arranged. Why don't be have all the logic related to

D6684: unshelve: modify --continue on interactive unshelve

2019-07-24 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > test-shelve.t:1354 >C > - $ hg unshelve --continue -i <> y This test change should be in the parent differential. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6684/new/ REVISION DETAIL

D6684: unshelve: modify --continue on interactive unshelve

2019-07-24 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `shelvedstate` should store info about interactive mode after D6679 . This patch modifies the test and behavior of