D6688: unshelve: make basename as a mandatory argument for unshelvecontinue()

2019-07-25 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added a comment. navaneeth.suresh abandoned this revision. Abandoning since changes in D6679 will make this obsolete. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6688/new/ REVISION DETAIL

D6688: unshelve: make basename as a mandatory argument for unshelvecontinue()

2019-07-25 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In D6688#97899 , @navaneeth.suresh wrote: > In D6688#97859 , @pulkit wrote: > >> Can you explain in commit description as why this is done? > > This patch will become

D6688: unshelve: make basename as a mandatory argument for unshelvecontinue()

2019-07-24 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added a comment. In D6688#97859 , @pulkit wrote: > Can you explain in commit description as why this is done? This patch will become obsolete after D6684 . Should I abandon this?

D6688: unshelve: make basename as a mandatory argument for unshelvecontinue()

2019-07-24 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Can you explain in commit description as why this is done? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6688/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6688 To: navaneeth.suresh, #hg-reviewers Cc: pulkit,

D6688: unshelve: make basename as a mandatory argument for unshelvecontinue()

2019-07-24 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D6688 AFFECTED FILES mercurial/shelve.py CHANGE DETAILS diff --git a/mercurial/shelve.py