Closed by commit rHG073cfff9aaef: unshelve: delete shelvedstate after a
successful unshelve --continue (authored by navaneeth.suresh).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs
Review".
navaneeth.suresh updated this revision to Diff 16142.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6694?vs=16133=16142
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6694/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6694
navaneeth.suresh added inline comments.
INLINE COMMENTS
> pulkit wrote in test-shelve.t:1430
> the above sentence is confusing and maybe incorrect too.
okay, maybe i should remove it. doing that right away.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
pulkit added inline comments.
INLINE COMMENTS
> test-shelve.t:1430
> +-- now, --continue should abort as the last unshelve was successful even
> +-- though it was partially done. it can be completed without --continue.
> + $ hg unshelve --continue
the above sentence is confusing and maybe
pulkit added a comment.
This fails to apply on tip of default. Can you rebase and resend?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6694/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6694
To: navaneeth.suresh, #hg-reviewers, durin42,
navaneeth.suresh marked an inline comment as done.
navaneeth.suresh updated this revision to Diff 16133.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6694?vs=16109=16133
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6694/new/
REVISION
pulkit added inline comments.
INLINE COMMENTS
> test-shelve.t:1436
> + $ hg shelve --list
> + default-01 (1s ago)changes to: add A to bars
> + default (1s ago)changes to: add B to foo
These timing needs to be globbed.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST
navaneeth.suresh updated this revision to Diff 16109.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6694?vs=16085=16109
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6694/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6694
This revision now requires changes to proceed.
durin42 added a comment.
durin42 requested changes to this revision.
needs rebased
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6694/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6694
To:
navaneeth.suresh edited the summary of this revision.
navaneeth.suresh retitled this revision from "unshelve: fix bug on a partial
unshelve with --continue" to "unshelve: delete shelvedstate after a successful
unshelve --continue".
navaneeth.suresh updated this revision to Diff 16085.
10 matches
Mail list logo