D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit()

This revision now requires changes to proceed. pulkit added a comment. pulkit requested changes to this revision. The test still fails. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6697/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6697

D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit()

navaneeth.suresh updated this revision to Diff 16110. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6697?vs=16073=16110 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6697/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6697

D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit()

navaneeth.suresh added a comment. In D6697#98061 , @pulkit wrote: > `test-commit-interactive.t` and some other tests fail for me with this, can you have a look? Doing that right away! REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit()

pulkit added a comment. `test-commit-interactive.t` and some other tests fail for me with this, can you have a look? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6697/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6697 To:

D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit()

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. > cmdutil: add allowunfinished to prevent checkunfinished() on docommit() s/docommit/dorecord/ in flight REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit()

navaneeth.suresh edited the summary of this revision. navaneeth.suresh updated this revision to Diff 16073. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6697?vs=16072=16073 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6697/new/ REVISION

D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit()

navaneeth.suresh added inline comments. INLINE COMMENTS > pulkit wrote in cmdutil.py:274 > Why not get rid of `interactive-shelve` passed by unshelve and make that pass > `allowunfinished=True` to dorecord? I thought of splitting into two patches. Will be amending the changes soon in this

D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit()

pulkit added inline comments. INLINE COMMENTS > cmdutil.py:274 > """ > -if not opts.get('interactive-unshelve'): > +if not (allowunfinished or opts.get('interactive-unshelve')): > checkunfinished(repo, commit=True) Why not get rid of `interactive-shelve`

D6697: cmdutil: add allowunfinished to prevent checkunfinished() on docommit()

navaneeth.suresh created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `cmdutil.dorecord()` has a `checkunfinished()` function call. We might not want to do that on certain occasions. For example, `unshelve --continue` on