D6710: branchmap: explicitly warm+write all subsets of the branchmap caches

Closed by commit rHGcdf0e9523de1: branchmap: explicitly warm+write all subsets of the branchmap caches (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6710?vs=

D6710: branchmap: explicitly warm+write all subsets of the branchmap caches

pulkit added a comment. Thanks @marmoute for the review. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6710/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6710 To: spectral, #hg-reviewers, marmoute, pulkit Cc: marmoute, mercurial-devel __

D6710: branchmap: explicitly warm+write all subsets of the branchmap caches

marmoute added a comment. marmoute accepted this revision. We could warm them in increasing order to improve efficiency. However this is for the full cache warming so this looks good enough. (consider doing them in order in a follow up) Note: this change seems independant from the previo

D6710: branchmap: explicitly warm+write all subsets of the branchmap caches

spectral added a comment. In D6710#98322 , @marmoute wrote: > Forcing this write seems like a good idea. Having it in its own > changeset seems like a good idea (and please add a comment about forcing > the write). I've split the 'full

Re: D6710: branchmap: explicitly warm+write all subsets of the branchmap caches

Forcing this write seems like a good idea. Having it in its own changeset seems like a good idea (and please add a comment about forcing the write). On 8/6/19 3:12 AM, spectral (Kyle Lippincott) wrote: spectral added inline comments. INLINE COMMENTS marmoute wrote in localrepo.py:2224 Why t

D6710: branchmap: explicitly warm+write all subsets of the branchmap caches

spectral added inline comments. INLINE COMMENTS > marmoute wrote in localrepo.py:2224 > Why the explicite write here ? We don't seems to need it for the previous > section. Is this because if the cache of the previous subset is valid, the > write would be skipped ? > If so, consider clarifying

D6710: branchmap: explicitly warm+write all subsets of the branchmap caches

spectral edited the summary of this revision. spectral retitled this revision from "branchmap: properly refresh/warm all branchmap caches" to "branchmap: explicitly warm+write all subsets of the branchmap caches". spectral marked an inline comment as done. spectral updated this revision to Diff 1