D6741: interfaces: create a new folder for interfaces and move repository.py in it

2019-08-25 Thread pulkit (Pulkit Goyal)
Closed by commit rHG268662aac075: interfaces: create a new folder for interfaces and move repository.py in it (authored by pulkit). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6741: interfaces: create a new folder for interfaces and move repository.py in it

2019-08-25 Thread indygreg (Gregory Szorc)
This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. It sounds like we're in agreement that interfaces need to be split. Moving everything to a sub-package seems like a logical first step. REPOSITORY rHG Mercurial CHANGES SINCE LAST

D6741: interfaces: create a new folder for interfaces and move repository.py in it

2019-08-20 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In D6741#99030 , @durin42 wrote: > In D6741#99023 , @pulkit wrote: > >> In D6741#98947 , @martinvonz wrote: >> I

D6741: interfaces: create a new folder for interfaces and move repository.py in it

2019-08-20 Thread durin42 (Augie Fackler)
durin42 added a comment. In D6741#99023 , @pulkit wrote: > In D6741#98947 , @martinvonz wrote: > >>> I was trying to understand current interfaces and write new ones and I realized >>> we need

D6741: interfaces: create a new folder for interfaces and move repository.py in it

2019-08-20 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In D6741#98947 , @martinvonz wrote: >> I was trying to understand current interfaces and write new ones and I realized >> we need to improve how current interfaces are organised. > > And what was the reason we

D6741: interfaces: create a new folder for interfaces and move repository.py in it

2019-08-19 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. > I was trying to understand current interfaces and write new ones and I realized > we need to improve how current interfaces are organised. And what was the reason we need to improve it? I assume we don't really "need" to change it. Will it somehow help

D6741: interfaces: create a new folder for interfaces and move repository.py in it

2019-08-17 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: indygreg. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I was trying to understand current interfaces and write new