D6848: narrow: add option for automatically removing unused includes

Closed by commit rHG40f78072fda9: narrow: add option for automatically removing unused includes (authored by martinvonz). martinvonz marked an inline comment as done. This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6848: narrow: add option for automatically removing unused includes

martinvonz added inline comments. martinvonz marked an inline comment as done. INLINE COMMENTS > pulkit wrote in narrowcommands.py:369 > sorry, but `currently visible commits` sounds like not correct as this can be > used in case of non-ellipses repository also. Good point. I've updated this a

D6848: narrow: add option for automatically removing unused includes

martinvonz updated this revision to Diff 16564. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6848?vs=16563&id=16564 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6848/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6848 AFFECTED FI

D6848: narrow: add option for automatically removing unused includes

pulkit added inline comments. INLINE COMMENTS > narrowcommands.py:369 > +If --auto-remove-includes is specified, then those includes that don't > match > +any files modified by currently visible commits will be added to the set > of > +explicitly specified includes to remove. sorry

D6848: narrow: add option for automatically removing unused includes

martinvonz edited the summary of this revision. martinvonz marked 2 inline comments as done. martinvonz updated this revision to Diff 16563. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6848?vs=16536&id=16563 CHANGES SINCE LAST ACTION https://phab.merc

D6848: narrow: add option for automatically removing unused includes

martinvonz added inline comments. INLINE COMMENTS > pulkit wrote in narrowcommands.py:331 > Following pattern of other flags, `auto-removeinclude(s)` seems better. I was also wondering about that. Maybe those should be changed instead? I'm not sure, but I think we're slowly transitioning option

D6848: narrow: add option for automatically removing unused includes

pulkit added inline comments. INLINE COMMENTS > narrowcommands.py:331 > ('', 'removeinclude', [], _('old paths to no longer include')), > + ('', 'auto-remove-includes', False, > + _('automatically choose unused includes to remove (EXPERIMENTAL)')), Following pattern of other flags

D6848: narrow: add option for automatically removing unused includes

martinvonz added inline comments. INLINE COMMENTS > pulkit wrote in narrowcommands.py:332 > Can you add some help text below on how these unused includes are calculated? Even though it's marked EXPERIMENTAL? Or maybe I should do that and just drop the EXPERIMENTAL since the whole feature (narro

D6848: narrow: add option for automatically removing unused includes

pulkit added inline comments. INLINE COMMENTS > narrowcommands.py:332 > + ('', 'auto-remove-includes', False, > + _('automatically choose unused includes to remove (EXPERIMENTAL)')), > ('', 'addexclude', [], _('new paths to exclude')), Can you add some help text below on how these

D6848: narrow: add option for automatically removing unused includes

martinvonz added inline comments. INLINE COMMENTS > martinvonz wrote in test-narrow.t:457 > > No, I meant what if you don't get rid of the .i files. > > This is not changing which .i files we get rid of; the behavior should be the > same as if you had typed `hg tracked --removeinclude path:d0 -

D6848: narrow: add option for automatically removing unused includes

martinvonz updated this revision to Diff 16536. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6848?vs=16532&id=16536 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6848/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6848 AFFECTED FI

D6848: narrow: add option for automatically removing unused includes

martinvonz updated this revision to Diff 16532. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6848?vs=16528&id=16532 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6848/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6848 AFFECTED FI

D6848: narrow: add option for automatically removing unused includes

martinvonz added inline comments. INLINE COMMENTS > rdamazio wrote in test-narrow.t:457 > > That's just about the working directory, right? This file is unchanged in > > the working directory at the time of hg tracked --auto-remove-includes... > > No, I meant what if you don't get rid of the .i

D6848: narrow: add option for automatically removing unused includes

rdamazio added inline comments. INLINE COMMENTS > martinvonz wrote in test-narrow.t:457 > > This obsolete commit is completely lost afterwards, which kind of violates > > the principle of "all changes are kept forever" - should it dump this > > somewhere for safekeeping? > > Yes, it does dump

D6848: narrow: add option for automatically removing unused includes

martinvonz added inline comments. INLINE COMMENTS > rdamazio wrote in test-narrow.t:457 > This obsolete commit is completely lost afterwards, which kind of violates > the principle of "all changes are kept forever" - should it dump this > somewhere for safekeeping? > Also, what if you just don'

D6848: narrow: add option for automatically removing unused includes

rdamazio added inline comments. INLINE COMMENTS > test-narrow.t:457 > + $ echo a >> d0/f > + $ hg ci -m 'local change to d0' > + $ hg co '.^' This obsolete commit is completely lost afterwards, which kind of violates the principle of "all changes are kept forever" - should it dump this somew

D6848: narrow: add option for automatically removing unused includes

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's been a somewhat common request among our users to have Mercurial automatically pick includes to remove. This patch adds a