Closed by commit rHGc42df030a9eb: sidedatacopies: get and store sidedata in the
changelogrevision object (authored by marmoute).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs
Review".
REPOSITORY
martinvonz added inline comments.
INLINE COMMENTS
> marmoute wrote in changelog.py:618-624
> Is a followup good enough for you ?
Yes, even leaving it inconsistent is good enough for me :) I don't care that
much
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
marmoute added inline comments.
INLINE COMMENTS
> martinvonz wrote in changelog.py:618-624
> nit: inconsistent way of calling the `changelogrevision` constructor between
> these two call sites
Is a followup good enough for you ?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
martinvonz added inline comments.
INLINE COMMENTS
> changelog.py:618-624
> +c = changelogrevision(*self._revisiondata(node))
> return (c.manifest, c.user, c.date, c.files, c.description, c.extra)
>
> def changelogrevision(self, nodeorrev):
> """Obtain a
marmoute updated this revision to Diff 16952.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D6951?vs=16783=16952
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D6951/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D6951
AFFECTED FILES
marmoute created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The object provide a simple way to access changelog entry, we need it to also
bear the sidedata value.
Since the sidedata are retrieved at the same time as
