D6987: strip: move strip extension to core as debugstrip

2019-10-09 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > strip.py:3 > > -This extension allows you to strip changesets and all their descendants from > the > -repository. See the command help for details. > +strip extension has been renamed to debugstrip and moved to core. However, > +this extension is

D6987: strip: move strip extension to core as debugstrip

2019-10-07 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > strip.py:1-47 > """strip changesets and their descendants from history > > -This extension allows you to strip changesets and all their descendants from > the > -repository. See the command help for details. > +strip extension has been renamed

D6987: strip: move strip extension to core

2019-10-06 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16914. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6987?vs=16856&id=16914 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6987/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6987 AFFEC

D6987: strip: move strip extension to core as debugstrip

2019-10-06 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added a comment. @durin42 Done, REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6987/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6987 To: navaneeth.suresh, durin42, #hg-reviewers Cc: mjpieters, mercurial-devel __

D6987: strip: move strip extension to core

2019-10-05 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > navaneeth.suresh wrote in commands.py:5646 > i see. do i need to replace `strip` by `debugstrip` on every occurrence in > tests? otherwise, i would have to revert the changes in the tests and keep > the extension as it is. One or two is fine, yo

D6987: strip: move strip extension to core

2019-10-05 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added inline comments. INLINE COMMENTS > durin42 wrote in commands.py:5646 > debugstrip please (and put it in debugcommands) > > and Gregory points out we need a strip extension that preserves the old > `strip` name for users that are used to that i see. do i need to replace `

D6987: strip: move strip extension to core

2019-10-05 Thread durin42 (Augie Fackler)
This revision now requires changes to proceed. durin42 added inline comments. durin42 requested changes to this revision. INLINE COMMENTS > commands.py:5646 > > +@command("strip", > +[ debugstrip please (and put it in debugcommands) and Gregory points out we need a strip extension that pr

D6987: strip: move strip extension to core

2019-10-05 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh created this revision. Herald added a reviewer: durin42. Herald added a reviewer: durin42. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Until now, `strip` was bootstrapped as an extension. This patch adds `strip`