D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz added a comment. martinvonz abandoned this revision. I'll abandon this in favor of D7492 REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7144/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7144

D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz added a comment. In D7144#109543 , @marmoute wrote: > I am working on a non-experimental series that get things more contained in repo/changectx to robustness. It also contains tests making sure we do not regress. I think we could

D7144: status: use unfiltered repo if we're getting status of working copy

marmoute added a comment. I am working on a non-experimental series that get things more contained in repo/changectx to robustness. It also contains tests making sure we do not regress. I think we could so something really robust, efficient and transparent, but having this and that filtered

D7144: status: use unfiltered repo if we're getting status of working copy

marmoute added a comment. In D7144#108574 , @martinvonz wrote: > In D7144#108444 , @marmoute wrote: > >> I took more time to look at your series and at the bigger picture. My general position

D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz added a comment. In D7144#108444 , @marmoute wrote: > I took more time to look at your series and at the bigger picture. My general position is still that passing the wrong filter level to high level function is hacking and will

D7144: status: use unfiltered repo if we're getting status of working copy

marmoute added a comment. I took more time to look at your series and at the bigger picture. My general position is still that passing the wrong filter level to high level function is hacking and will be a significant source of bugs. For example, `hg status` taks a "PATTERN" argument,

D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz added a comment. martinvonz marked an inline comment as done. I've extracted a function for deciding whether to use an unfiltered repo, so hopefully this can get queued now. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7144/new/ REVISION

D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz edited the summary of this revision. martinvonz updated this revision to Diff 18044. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7144?vs=17367=18044 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7144/new/ REVISION DETAIL

D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz added a comment. In D7144#105248 , @mharbison72 wrote: > The comment about maybe affecting extensions made me think of df463ca0adef . I never figured out

D7144: status: use unfiltered repo if we're getting status of working copy

marmoute added a comment. In D7144#105048 , @martinvonz wrote: > In D7144#105039 , @marmoute wrote: > >> I have a couple of questions: >> >> […] >> >> - This could cause issue

D7144: status: use unfiltered repo if we're getting status of working copy

mharbison72 added a comment. The comment about maybe affecting extensions made me think of df463ca0adef . I never figured out what the issue was. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz added a comment. In D7144#105048 , @martinvonz wrote: > In D7144#105039 , @marmoute wrote: > >> I have a couple of questions: >> >> - Can we get performance number with about

D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz added a comment. In D7144#105065 , @marmoute wrote: > Another question is " Why are we loading the changelog if we don't need it ?". If the code were not accessing the changelog, we could not pay the filtering code (and save other

D7144: status: use unfiltered repo if we're getting status of working copy

marmoute added a comment. Another question is " Why are we loading the changelog if we don't need it ?". If the code were not accessing the changelog, we could not pay the filtering code (and save other parsing cost). REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7144: status: use unfiltered repo if we're getting status of working copy

marmoute added inline comments. INLINE COMMENTS > commands.py:6774 > +if not revs and not change: > +# Avoid loading obsmarkers if we're accessing only the working copy > +# parent (which will never be hidden). Are you using the evolve extension. If so you should -already-

D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz added a comment. In D7144#105039 , @marmoute wrote: > I have a couple of questions: > > - Can we get performance number with about without this patch ? (to gauge the relative gain) Will get that later (I have ~2 weeks

D7144: status: use unfiltered repo if we're getting status of working copy

pulkit added a comment. I am +1 on this idea. I see @marmoute has some concerns around extensions wrapping, once they are addressed, I will push it once the freeze ends. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7144/new/ REVISION DETAIL

D7144: status: use unfiltered repo if we're getting status of working copy

marmoute added a comment. I have a couple of questions: - Can we get performance number with about without this patch ? (to gauge the relative gain) - This could cause issue to extensions, can we abtract the unfiltering though a function so that extension can rewrap it ? REPOSITORY

D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz updated this revision to Diff 17367. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7144?vs=17356=17367 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7144/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7144 AFFECTED

D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz added a comment. To reviewers: I only care about this patch (and its parent is needed for this to pass tests). Feel free to drop any other patches you don't like. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7144/new/ REVISION DETAIL

D7144: status: use unfiltered repo if we're getting status of working copy

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Loading the filtered repo can be slow if there are many obsmarkers and it's not needed in the plain `hg status` case. This saves about 60ms in my hg repo and