D7166: packaging: ship all help .txt files on WiX

durin42 added a comment. No worries, I'm not sure what went sideways there. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7166/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7166 To: indygreg, #hg-reviewers Cc: durin42, martinvonz,

D7166: packaging: ship all help .txt files on WiX

martinvonz added a comment. In D7166#108360 , @durin42 wrote: > I re-landed this and tests passed on my workstation when I did so. Let's not drop this again without some additional coordination? Agreed. I think it was I who pushed it last

D7166: packaging: ship all help .txt files on WiX

durin42 added a comment. I re-landed this and tests passed on my workstation when I did so. Let's not drop this again without some additional coordination? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7166/new/ REVISION DETAIL

D7166: packaging: ship all help .txt files on WiX

durin42 added a comment. In D7166#108320 , @indygreg wrote: > This got dropped on committed but Phabricator is confused about its closedstate. Please re-review and land @martinvonz or @durin42. Per Martin's comment, it looks like you had

D7166: packaging: ship all help .txt files on WiX

indygreg added a comment. indygreg added a subscriber: durin42. This got dropped on committed but Phabricator is confused about its closedstate. Please re-review and land @martinvonz or @durin42. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7166: packaging: ship all help .txt files on WiX

indygreg updated this revision to Diff 18031. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7166?vs=17818=18031 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7166/new/ REVISION DETAIL

D7166: packaging: ship all help .txt files on WiX

martinvonz added a comment. I get this test failure from this commit: @@ -223,11 +223,6 @@ $ ( testrepohgenv; "$PYTHON" wixxml.py help ) Not installed: -help/common.txt -help/hg-ssh.8.txt -help/hg.1.txt -help/hgignore.5.txt -

D7166: packaging: ship all help .txt files on WiX

Closed by commit rHGe7896eaca05f: packaging: ship all help .txt files on WiX (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D7166: packaging: ship all help .txt files on WiX

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These are technically not needed. But it is easier to ship all files than to cherry-pick. A `make install` will copy these files, so the new behavior is