D723: templates: introduce a obsfateoperation() function

2017-09-20 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7cdc8c5a481a: templates: introduce a obsfateoperation() function (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D723: templates: introduce a obsfateoperation() function

2017-09-20 Thread quark (Jun Wu)
quark added a comment. In https://phab.mercurial-scm.org/D723#12511, @martinvonz wrote: > This is just a test case, do we really care that much? (I don't :-)) No. I thought there is a default template. But there isn't. REPOSITORY rHG Mercurial REVISION DETAIL

D723: templates: introduce a obsfateoperation() function

2017-09-20 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D723#12507, @quark wrote: > +1 for changing the words. I think it should be just "split as " or "amend as " etc without the word "rewritten". People want the "rewritten" word could customize their own templates.

D723: templates: introduce a obsfateoperation() function

2017-09-20 Thread quark (Jun Wu)
quark added a comment. +1 for changing the words. I think it should be just "split as " or "amend as " etc without the word "rewritten". People want the "rewritten" word could customize their own templates. REPOSITORY rHG Mercurial REVISION DETAIL

D723: templates: introduce a obsfateoperation() function

2017-09-20 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. I'm +1 with "rewritten using amend as". I find it useful as a complement to the verb. I'm -0 with "split using amend, rebase as". It find it harder to read and understand even if it brings some value. REPOSITORY rHG Mercurial REVISION DETAIL

D723: templates: introduce a obsfateoperation() function

2017-09-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 1866. martinvonz marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D723?vs=1861=1866 REVISION DETAIL https://phab.mercurial-scm.org/D723 AFFECTED FILES mercurial/obsutil.py

D723: templates: introduce a obsfateoperation() function

2017-09-18 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > lothiraldan wrote in test-obsmarker-template.t:20 > Could you fix https://phab.mercurial-scm.org/D722 so we don't have this > renaming here? Oops, it wasn't supposed to be in https://phab.mercurial-scm.org/D722 at all. Thanks for spotting

D723: templates: introduce a obsfateoperation() function

2017-09-15 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 1861. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D723?vs=1858=1861 REVISION DETAIL https://phab.mercurial-scm.org/D723 AFFECTED FILES mercurial/obsutil.py mercurial/templater.py

D723: templates: introduce a obsfateoperation() function

2017-09-15 Thread quark (Jun Wu)
quark accepted this revision. quark added a comment. I think this is a good step forward. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D723 To: martinvonz, #hg-reviewers, quark Cc: quark, mercurial-devel ___

D723: templates: introduce a obsfateoperation() function

2017-09-15 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D723 AFFECTED FILES mercurial/obsutil.py mercurial/templater.py tests/test-obsmarker-template.t