Closed by commit rHG548881608444: index: use `index.get_rev` in
`repoview.pinnedrevs` (authored by marmoute).
This revision was automatically updated to reflect the committed changes.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D7337?vs=17844=17896
marmoute marked an inline comment as done.
marmoute updated this revision to Diff 17844.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D7337?vs=17760=17844
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7337/new/
REVISION DETAIL
marmoute added inline comments.
marmoute marked 2 inline comments as done.
INLINE COMMENTS
> indygreg wrote in repoview.py:64
> Nevermind. This `get_rev()` can return `None`.
Yeah, it is simpler to filter out None at the end than to do a lookup before
adding to the set.
REPOSITORY
rHG
This revision is now accepted and ready to land.
indygreg added inline comments.
indygreg accepted this revision.
INLINE COMMENTS
> indygreg wrote in repoview.py:64
> Why was `pinned.discard(None)` added?
Nevermind. This `get_rev()` can return `None`.
REPOSITORY
rHG Mercurial
CHANGES SINCE
indygreg added inline comments.
INLINE COMMENTS
> repoview.py:64
> +pinned.update(rev(t[0]) for t in tags.values())
> +pinned.discard(None)
> return pinned
Why was `pinned.discard(None)` added?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
marmoute created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We simplify the code in the process
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D7337
AFFECTED FILES
mercurial/repoview.py
