pulkit abandoned this revision.
pulkit added a comment.
Resend the series as https://phab.mercurial-scm.org/D1140 -
https://phab.mercurial-scm.org/D1144.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D738
To: pulkit, #hg-reviewers, durham, ryanmce
Cc: ryanmce,
pulkit added inline comments.
INLINE COMMENTS
> ryanmce wrote in test-directaccess.t:64
> This is showing the rev numbers are not supported, right?
Yes!
> ryanmce wrote in test-directaccess.t:23-35
> Why so many commits here? It seems to needlessly bloat the test.
Okay will fix in next
ryanmce requested changes to this revision.
ryanmce added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> durham wrote in test-directaccess.t:64
> I'm still not sure we want to support rev numbers. I think we definitely
> don't want to support them for write
pulkit updated this revision to Diff 2598.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D738?vs=1906=2598
REVISION DETAIL
https://phab.mercurial-scm.org/D738
AFFECTED FILES
mercurial/commands.py
tests/test-directaccess.t
CHANGE DETAILS
diff
durham accepted this revision.
durham added inline comments.
INLINE COMMENTS
> test-directaccess.t:11
> + > [extensions]
> + > uncommit =
> + > amend =
Do we need uncommit? It doesn't seem used.
> test-directaccess.t:64
> +
> + $ hg exp 7
> + # HG changeset patch
I'm still not sure we
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This patch adds the cmdtype attribute to export command which is a read only
command and adds test for accessing hidden commits using the same command.
REPOSITORY
