dlax added inline comments.
INLINE COMMENTS
> dlax wrote in extensions.py:96
> the doc indeed says that "fd" is file object
In https://github.com/python/typeshed/blob/master/stdlib/3/imp.pyi type of
`find_module` seems wrong.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
dlax added inline comments.
dlax accepted this revision.
INLINE COMMENTS
> extensions.py:96
> +# pytype seems to think `fd` is a str, but I'm pretty sure
> +# it's wrong. This may be a bug we need to report upstream.
> +return imp.load_module(
the doc indeed says that
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I suspect a bug in pytype here, but I'll follow up with that later. We
have good enough coverage on this that I'm happy to move on for now.
REPOSITORY
rHG
