D7464: filemerge: drop a default argument to appease pytype

2019-12-11 Thread mharbison72 (Matt Harbison)
Closed by commit rHG1ffbd03c8d75: filemerge: drop a default argument to appease pytype (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7464: filemerge: drop a default argument to appease pytype

2019-12-01 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In D7464#109795 , @dlax wrote: > Shouldn't this be also done for all similar functions? (i.e. `_xmergeimm` and functions registered as a merge tool with `@internaltool`) I looked at this a bit more, and it

D7464: filemerge: drop a default argument to appease pytype

2019-11-21 Thread dlax (Denis Laxalde)
dlax added a comment. Shouldn't this be also done for all similar functions? (i.e. `_xmergeimm` and functions registered as a merge tool with `@internaltool`) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7464/new/ REVISION DETAIL

D7464: filemerge: drop a default argument to appease pytype

2019-11-20 Thread mharbison72 (Matt Harbison)
mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The function slices and takes the length of this argument without internally setting it if not provided. There was no bug here because both callers passed