D7504: py3: replace %s by %r on binary format string when needed

2019-11-22 Thread matclab (Mathieu Clabaut)
matclab added a comment. matclab abandoned this revision. INLINE COMMENTS > dlax wrote in localrepo.py:1571 > The first `%s` was correct I think because `changeid` can be a bytes. > > For the second one, if `%r` is the way to go (I'm not sure), maybe we can > drop `pycompat.sysstr()`? I'm r

D7504: py3: replace %s by %r on binary format string when needed

2019-11-22 Thread dlax (Denis Laxalde)
This revision now requires changes to proceed. dlax added a comment. dlax requested changes to this revision. nit: the actual PEP is pep-0461 (https://www.python.org/dev/peps/pep-0461/) INLINE COMMENTS > localrepo.py:1571 > +b"unsupported changeid '%r' of type %r" >

D7504: py3: replace %s by %r on binary format string when needed

2019-11-22 Thread matclab (Mathieu Clabaut)
matclab created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY For some error, mercurial displays the type of a variable. However the formatting string used was "%s" which is not compatible with `type` and lead to an excpeti