D7516: webutil: add missing argument to join()

2019-11-24 Thread mharbison72 (Matt Harbison)
Closed by commit rHG371765e775a2: webutil: add missing argument to join() (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D7516: webutil: add missing argument to join()

2019-11-24 Thread yuja (Yuya Nishihara)
yuja added a comment. > It could be, since I didn’t see any callers either (but wasn’t sure if there was templater magic in play here). It also might be a WIP, given the comment in `join()`. @yuja? `{sessionvars}` (with no `%template`) would crash without this change. Queued,

Re: D7516: webutil: add missing argument to join()

2019-11-24 Thread Yuya Nishihara
> It could be, since I didn’t see any callers either (but wasn’t sure if > there was templater magic in play here). It also might be a WIP, given the > comment in `join()`. @yuja? `{sessionvars}` (with no `%template`) would crash without this change. Queued, thanks.

D7516: webutil: add missing argument to join()

2019-11-24 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. mharbison72 added a subscriber: yuja. In D7516#110537 , @dlax wrote: > Looks like dead code It could be, since I didn’t see any callers either (but wasn’t sure if there was templater magic in play here). It

D7516: webutil: add missing argument to join()

2019-11-24 Thread dlax (Denis Laxalde)
dlax added a comment. dlax accepted this revision. Looks like dead code REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7516/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7516 To: mharbison72, #hg-reviewers, dlax Cc: dlax, mercurial-devel

D7516: webutil: add missing argument to join()

2019-11-23 Thread mharbison72 (Matt Harbison)
mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH stable REVISION DETAIL https://phab.mercurial-scm.org/D7516 AFFECTED FILES mercurial/hgweb/webutil.py CHANGE DETAILS diff --git