martinvonz added a comment.
I was just going to note that it seems like this would not work on Windows,
but then I saw Jun's comment which seems to suggest the same. I'll send a patch
to switch to Jun's proposal.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
Closed by commit rHG6e13b31f83b5: examples: specify rustfmt nightly using a $()
construct (authored by durin42).
This revision was automatically updated to reflect the committed changes.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D7812?vs=19087=19210
gracinet added a comment.
@pulkit yes, after toolchain reinstall, this rustup which works for me
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7812/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7812
To: durin42, #hg-reviewers
Cc: pulkit,
pulkit added a comment.
@gracinet Does this looks good to you?
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7812/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7812
To: durin42, #hg-reviewers
Cc: pulkit, quark, gracinet, mercurial-devel
gracinet added a comment.
Ok, so yes I had an old version of rustfmt-nightly, dating back to the days
it wasn't managed by rustup (crate `rustfmt-nightly`).
Thanks for the heads up, guys.
Now I'm pretty sure that `cargo +nightly fmt` just calls `rustup +nightly
fmt`.
REPOSITORY
rHG
quark added a comment.
You can use `rustfmt +nightly` if it's installed by rustup.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7812/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7812
To: durin42, #hg-reviewers
Cc: quark, gracinet,
gracinet added a comment.
thanks for the tip. Fun fact: `rustup which` doesn't have a --toolchain
option on my system, so perhaps it needs to be itself upgraded, (and that might
explain a few things.
I've been using rustmt nightly since forever, but maybe I'm stuck on an old
version of
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is ugly, but it's how we have to configure rustfmt for now as we
require nightly rustfmt.
REPOSITORY
rHG Mercurial
BRANCH
default
REVISION DETAIL
