marmoute added inline comments.
INLINE COMMENTS
> mharbison72 wrote in debugcommands.py:3432
> I thought we were trying to avoid `os.path`, so maybe just
> `repo.vfs.join("strip-backup", ".hg")`?
>
> (And don't these need to be `b''` prefixed for py3?)
+1 on using `vfs` here, this is the abstr
mharbison72 added inline comments.
INLINE COMMENTS
> martinvonz wrote in debugcommands.py:3432
> I think Windows doesn't care much about `/` vs `\`, but should we ideally use
> `os.path.join(..., ".hg")` here?
I thought we were trying to avoid `os.path`, so maybe just
`repo.vfs.join("strip-bac
martinvonz added a comment.
I know this has already been queue and I'm just slow, but could you send
follow-up patches to address my comments?
INLINE COMMENTS
> debugcommands.py:3416
> +]
> ++ cmdutil.logopts,
> +_(b"hg debugbackupbundle [--recover HASH]"),
Do we really want to
Closed by commit rHG89323f85176e: debugbackupbundle: introduce command to
interact with strip backups (authored by pulkit).
This revision was automatically updated to reflect the committed changes.
This revision was not accepted when it landed; it landed in state "Needs
Review".
CHANGED PRIOR TO
pulkit retitled this revision from "debugstripbackups: introduce command to
interact with strip backups" to "debugbackupbundle: introduce command to
interact with strip backups".
pulkit updated this revision to Diff 20288.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.merc
