D7965: py3: catch AttributeError too with ImportError

2020-02-06 Thread pulkit (Pulkit Goyal)
Closed by commit rHG9a92b29cf930: py3: catch AttributeError too with ImportError (authored by pulkit). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES

D7965: py3: catch AttributeError too with ImportError

2020-02-05 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute accepted this revision. Sounds reasonable REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7965/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7965 To: pulkit, #hg-reviewers, marmoute Cc: marmoute,

D7965: py3: catch AttributeError too with ImportError

2020-01-21 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Looks like py3 raises AttributeError instead of ImportError. This is caught on windows. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL