Closed by commit rHG5fb0592f90e7: exchange: check the `ui.clonebundleprefers`
form while processing (issue6257) (authored by mharbison72).
This revision was automatically updated to reflect the committed changes.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
marmoute added a comment.
marmoute accepted this revision.
Thanks
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7969/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7969
To: mharbison72, #hg-reviewers, marmoute
Cc: marmoute, mercurial-devel
mharbison72 updated this revision to Diff 19984.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D7969?vs=19517=19984
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D7969/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D7969
AFFECTED
marmoute added inline comments.
INLINE COMMENTS
> mharbison72 wrote in test-clonebundles.t:458-464
> Not sure I understand. There are a handful of tests in test-clonebundles.t
> that have multiple key/value pairs already, so the good case is covered. (I
> missed this before and thought that
mharbison72 added inline comments.
mharbison72 requested review of this revision.
INLINE COMMENTS
> marmoute wrote in test-clonebundles.t:458-464
> Your patch is about testing error when only one of the items is bad. Then,
> your tests only test it with a single item. Am I missing something or
This revision now requires changes to proceed.
marmoute added a comment.
marmoute requested changes to this revision.
(feel free to put it back in review-needed if my question was silly).
INLINE COMMENTS
> test-clonebundles.t:458-464
> +Test a bad attribute list
> +
> + $ hg --config
mharbison72 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Otherwise the clone command will emit a long stacktrace if there is no `=`
character.
REPOSITORY
rHG Mercurial
BRANCH
stable
REVISION DETAIL
