D7972: recover: don't verify by default

Closed by commit rHG7a4e1d245f19: recover: dont verify by default (authored by valentin.gatienbaron). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7972?vs=19520=20168 CHANGES

D7972: recover: don't verify by default

This revision is now accepted and ready to land. durin42 added a comment. durin42 accepted this revision. In D7972#120504 , @valentin.gatienbaron wrote: >> I _think_ it's just paranoia. As long as the bundle wasn't woefully corrupt, it

D7972: recover: don't verify by default

valentin.gatienbaron added a comment. > I _think_ it's just paranoia. As long as the bundle wasn't woefully corrupt, it shouldn't be a problem. I _think_ if we set some of the [server]-section bundle validation options (which should be cheap enough) we could ditch this completely safely.

D7972: recover: don't verify by default

durin42 added a comment. durin42 accepted this revision as: durin42. In D7972#120111 , @pulkit wrote: > Sorry for late reply. By changing the default, I am afraid about the cases where a user has broken repository and we only recover the

D7972: recover: don't verify by default

pulkit added a comment. pulkit added a subscriber: durin42. Sorry for late reply. By changing the default, I am afraid about the cases where a user has broken repository and we only recover the transaction and don't verify. I am not sure what those cases are. Also I don't know why recover

D7972: recover: don't verify by default

valentin.gatienbaron added a comment. It's already possible to control the default, like so: [alias] recover = recover --no-verify So the current patch is meant to change a default. Or be abandoned, which would be fine too given that it's easy to change the default for

D7972: recover: don't verify by default

marmoute added a comment. +1, the point of having the --no-verify option was to eventualy turn it on by default. (also, we shoudl tighten the windows the transaction creation that requires `hg recover`) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7972: recover: don't verify by default

pulkit added a comment. I also have experience with C-c thing. Will a config option which enables `--no-verify` by default will work for you? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7972/new/ REVISION DETAIL

D7972: recover: don't verify by default

valentin.gatienbaron created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The reason is: - it's not that hard to trigger interrupted transactions: just run out of disk space - it takes forever to verify on