D8078: copies: add a new test dedicated to testing chain of changeset with merge

marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in test-copies-chain-merge.t:349-386 > How about setting up the *branches* first then, and then the merges together > with the verification? I tried that too and was not very convinced. Especially now that we have all the test

D8078: copies: add a new test dedicated to testing chain of changeset with merge

martinvonz added inline comments. INLINE COMMENTS > marmoute wrote in test-copies-chain-merge.t:349-386 > Because what you suggest cannot be achieve. Since we reuse branches for > various cases, we cannot have the tests close to the definition of their > branches. I tried, it was confusing and

D8078: copies: add a new test dedicated to testing chain of changeset with merge

marmoute added inline comments. INLINE COMMENTS > marmoute wrote in test-copies-chain-merge.t:259-293 > This is pretty much the same test. In a more systemic effort. (also, with more chaining) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8078/new/

D8078: copies: add a new test dedicated to testing chain of changeset with merge

marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in test-copies-chain-merge.t:1 > Why doesn't this one have a `#testcases` line like `test-copies.t` does? It > seems useful to check that how these cases work when copies are stored in > changesets or sidedata too, right?

D8078: copies: add a new test dedicated to testing chain of changeset with merge

martinvonz added a comment. Sorry that I missed the review of this patch earlier. I hope you can still address my comments and send any resulting changes as follow-up patches in the same series as D8235 . INLINE COMMENTS > test-copies-chain-merge.t:1 >

D8078: copies: add a new test dedicated to testing chain of changeset with merge

Closed by commit rHG820bcb4875f7: copies: add a new test dedicated to testing chain of changeset with merge (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D8078: copies: add a new test dedicated to testing chain of changeset with merge

marmoute added a comment. Yeah, not it is. I added extra comment and output to review and clarify things. FYI, coming next on this topic is fixing some inconsistency and then fixing then changeset centric behavior. (but do not hold your breath, nodemap has an higher priority)

D8078: copies: add a new test dedicated to testing chain of changeset with merge

martinvonz added a comment. In D8078#119493 , @marmoute wrote: > oops, this one got out by mistake. But now it's ready for review (seems ready to me)? Thanks for adding these tests. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D8078: copies: add a new test dedicated to testing chain of changeset with merge

marmoute edited the summary of this revision. marmoute retitled this revision from "tests/test-copies-chain-merge.t" to "copies: add a new test dedicated to testing chain of changeset with merge". marmoute updated this revision to Diff 19931. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE