Closed by commit rHG483fce658e43: rust-status: refactor options into a
`StatusOptions` struct (authored by Alphare).
This revision was automatically updated to reflect the committed changes.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
Alphare updated this revision to Diff 20496.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D8086?vs=20184=20496
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8086/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8086
marmoute added a comment.
marmoute accepted this revision.
looks good to me. thanks for plitting
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8086/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8086
To: Alphare, #hg-reviewers, marmoute
Cc:
Alphare updated this revision to Diff 20184.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D8086?vs=20164=20184
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8086/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8086
Alphare updated this revision to Diff 20164.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D8086?vs=20155=20164
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8086/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8086
Alphare updated this revision to Diff 20155.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D8086?vs=20044=20155
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8086/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8086
Alphare updated this revision to Diff 20044.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D8086?vs=19943=20044
BRANCH
default
CHANGES SINCE LAST ACTION
https://phab.mercurial-scm.org/D8086/new/
REVISION DETAIL
https://phab.mercurial-scm.org/D8086
Alphare added inline comments.
INLINE COMMENTS
> kevincox wrote in status.rs:208
> These names aren't very meaningful to me but maybe that is because I'm not
> super familiar with the domain.
It doesn't hurt to have some documentation. They're not super obvious indeed.
REPOSITORY
rHG
kevincox added inline comments.
INLINE COMMENTS
> status.rs:208
> +pub list_clean: bool,
> +}
> +
These names aren't very meaningful to me but maybe that is because I'm not
super familiar with the domain.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST ACTION
Alphare created this revision.
Herald added subscribers: mercurial-devel, kevincox.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
BRANCH
default
REVISION DETAIL
https://phab.mercurial-scm.org/D8086
AFFECTED FILES
rust/hg-core/src/dirstate/status.rs
10 matches
Mail list logo
