D8092: hghave: cache the result of gethgversion

2020-02-07 Thread jcristau (Julien Cristau)
Closed by commit rHG8607dc2aa686: hghave: cache the result of gethgversion (authored by jcristau). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8092?vs=19985=19998 CHANGES SINCE

D8092: hghave: cache the result of gethgversion

2020-02-07 Thread jcristau (Julien Cristau)
jcristau added a comment. It fixes a longstanding issue in tests, it's not particularly urgent IMO. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8092/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8092 To: jcristau, #hg-reviewers, marmoute

D8092: hghave: cache the result of gethgversion

2020-02-07 Thread pulkit (Pulkit Goyal)
pulkit added a comment. This is fixing some debian packaging issue, so is it targeted for stable branch? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8092/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8092 To: jcristau, #hg-reviewers,

D8092: hghave: cache the result of gethgversion

2020-02-07 Thread marmoute (Pierre-Yves David)
marmoute added a comment. I can confirm the perf win: before: 10.687 seconds after 3.6.19 seconds REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8092/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8092 To: jcristau, #hg-reviewers Cc:

D8092: hghave: cache the result of gethgversion

2020-02-07 Thread jcristau (Julien Cristau)
jcristau created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY hghave --test-features calls it 90 times, each one calling hg --version which takes a tenth of a second on my workstation, adding up to about 10s win on