D8281: narrow: escape includepats/excludepats when sending over the wire

Herald added a subscriber: mercurial-patches. This revision now requires changes to proceed. marmoute added a comment. marmoute requested changes to this revision. If I understood the situation correctly, a rewrite in planned. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://pha

D8281: narrow: escape includepats/excludepats when sending over the wire

marmoute added a comment. In D8281#124246 , @spectral wrote: > In D8281#124129 , @durin42 wrote: > >> In D8281#124058 , @marmoute wrote: >> >>>

D8281: narrow: escape includepats/excludepats when sending over the wire

mharbison72 added a comment. In D8281#124246 , @spectral wrote: > - I'm *not* expecting to do anything about `\` -> `/` conversion. So would there be some interoperability issue between Windows and not-Windows if paths aren't pconverted,

D8281: narrow: escape includepats/excludepats when sending over the wire

spectral added a comment. In D8281#124247 , @martinvonz wrote: > In D8281#124246 , @spectral wrote: > >> - Server emits a new capability `narrow-exp-1-escaped` (in addition to the current `narr

D8281: narrow: escape includepats/excludepats when sending over the wire

martinvonz added a comment. In D8281#124246 , @spectral wrote: > In D8281#124129 , @durin42 wrote: > >> In D8281#124058 , @marmoute wrote: >> >>

D8281: narrow: escape includepats/excludepats when sending over the wire

spectral added a comment. In D8281#124129 , @durin42 wrote: > In D8281#124058 , @marmoute wrote: > >> Since narrow is still experimental, I don't think we should try too hard for backward compat

D8281: narrow: escape includepats/excludepats when sending over the wire

durin42 added a comment. In D8281#124058 , @marmoute wrote: > Since narrow is still experimental, I don't think we should try too hard for backward compatibility. We could introduce a new end-point for a new encoding and drop the old one in a

D8281: narrow: escape includepats/excludepats when sending over the wire

marmoute added a comment. Since narrow is still experimental, I don't think we should try too hard for backward compatibility. We could introduce a new end-point for a new encoding and drop the old one in a couple of version. I am really not enthousiatic with having our own version of an

D8281: narrow: escape includepats/excludepats when sending over the wire

spectral updated this revision to Diff 20819. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8281?vs=20818&id=20819 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8281/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8281: narrow: escape includepats/excludepats when sending over the wire

spectral updated this revision to Diff 20818. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8281?vs=20813&id=20818 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8281/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8281: narrow: escape includepats/excludepats when sending over the wire

spectral edited the summary of this revision. spectral retitled this revision from "narrow: escape includepats/excludepats when sending over the wire (BC)" to "narrow: escape includepats/excludepats when sending over the wire". spectral updated this revision to Diff 20813. REPOSITORY rHG Mercu

D8281: narrow: escape includepats/excludepats when sending over the wire (BC)

spectral updated this revision to Diff 20789. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8281?vs=20767&id=20789 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8281/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8281: narrow: escape includepats/excludepats when sending over the wire (BC)

martinvonz added a comment. In D8281#123659 , @mharbison72 wrote: > In D8281#123625 , @spectral wrote: > >> In D8281#123621 , @mharbison72 wrote:

D8281: narrow: escape includepats/excludepats when sending over the wire (BC)

mharbison72 added a comment. In D8281#123625 , @spectral wrote: > In D8281#123621 , @mharbison72 wrote: > >> The Windows path changes seem like a good idea. >> Would quoting paths with commas

D8281: narrow: escape includepats/excludepats when sending over the wire (BC)

This revision now requires changes to proceed. marmoute added a comment. marmoute requested changes to this revision. The escaping scheme is a bit puzzling to me. Coudl we use something more standard for this ? (like urlencode). (requesting change of the function name. Now that we can, le

D8281: narrow: escape includepats/excludepats when sending over the wire (BC)

martinvonz added a comment. In D8281#123625 , @spectral wrote: > In D8281#123621 , @mharbison72 wrote: > >> The Windows path changes seem like a good idea. >> Would quoting paths with commas e

D8281: narrow: escape includepats/excludepats when sending over the wire (BC)

spectral added a comment. In D8281#123621 , @mharbison72 wrote: > The Windows path changes seem like a good idea. > Would quoting paths with commas eliminate the need for custom escaping? I don't feel strongly about it, but custom escaping

D8281: narrow: escape includepats/excludepats when sending over the wire (BC)

spectral updated this revision to Diff 20767. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D8281?vs=20765&id=20767 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8281/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8

D8281: narrow: escape includepats/excludepats when sending over the wire (BC)

mharbison72 added a comment. The Windows path changes seem like a good idea. Would quoting paths with commas eliminate the need for custom escaping? I don't feel strongly about it, but custom escaping always feels weird to me. (I fact, a coworker did some homebrew escaping for CSV file

D8281: narrow: escape includepats/excludepats when sending over the wire (BC)

spectral created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When transmitting data over the wire, first run util.pconvert on each item (this is just g