lothiraldan added a comment.
The perf difference is not big, but I'm not sure if it's due to the import
time of attrs because basic_commands.TimeTestSuite.time_version didn't change
much. I have the impression that we pay a cost the first time an attrs-based
class is instantiated.
I've
durin42 added a comment.
@lothiraldan you very much buried the lede here (lots of data about things
that didn't change, but no inline data on what didn't). The regressions appear
to be:
basic_commands.TimeTestSuite.time_id_current('mercurial-2017') 43.922ms ->
46.190ms
lothiraldan added a comment.
We detected a small performance regression on this changeset thanks to our
ASV instance: http://perf.octobus.net/#regressions?sort=3=desc (look for
https://phab.mercurial-scm.org/rHGe51c8ffa1ffa3524e01cd1d1f60c79fc5ef02e43).
It seems to have slow down enough
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe51c8ffa1ffa: changelog: use attrs instead of namedtuple
(authored by sid0, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D868?vs=2232=2252#toc
REPOSITORY
rHG Mercurial
sid0 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
See http://www.attrs.org/en/stable/why.html#namedtuples for why attrs are
better than namedtuples.
REPOSITORY
rHG Mercurial
REVISION DETAIL
