D897: context: rename local 'attr' to 'attr_'

2017-10-02 Thread sid0 (Siddharth Agarwal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG52e9310626a8: context: rename local attr to attr_ (authored by sid0, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D897?vs=2318=2339 REVISION

D897: context: rename local 'attr' to 'attr_'

2017-10-02 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. I could bikeshed the naming. But if there isn't automated style checking to flag it as bad, then it's good. REPOSITORY rHG Mercurial REVISION DETAIL

D897: context: rename local 'attr' to 'attr_'

2017-10-02 Thread sid0 (Siddharth Agarwal)
sid0 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In the next diff we're going to import mercurial.thirdparty.attr, and pyflakes complains about this if this rename isn't done. REPOSITORY rHG Mercurial REVISION