Re: D937: remotenames: move function to pull remotenames from the remoterepo to core

2017-11-01 Thread Sean Farley
pulkit (Pulkit Goyal) writes: > pulkit created this revision. > Herald added a subscriber: mercurial-devel. > Herald added a reviewer: hg-reviewers. > > REVISION SUMMARY > This patch moves the functionality to pull branches and bookmarks from a > server from

D937: remotenames: move function to pull remotenames from the remoterepo to core

2017-10-16 Thread pulkit (Pulkit Goyal)
pulkit abandoned this revision. pulkit added a comment. In https://phab.mercurial-scm.org/D937#17855, @durin42 wrote: > Could we try and get this series ready to land before the freeze on Wednesday? or should we be aiming to get this early in the 4.5 cycle? Me and @ryanmce were

D937: remotenames: move function to pull remotenames from the remoterepo to core

2017-10-14 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D937#17855, @durin42 wrote: > Could we try and get this series ready to land before the freeze on Wednesday? or should we be aiming to get this early in the 4.5 cycle? Yes, I will be trying to get this series ready to land

D937: remotenames: move function to pull remotenames from the remoterepo to core

2017-10-13 Thread durin42 (Augie Fackler)
durin42 added a comment. Could we try and get this series ready to land before the freeze on Wednesday? or should we be aiming to get this early in the 4.5 cycle? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D937 To: pulkit, #hg-reviewers, dlax, ryanmce Cc:

D937: remotenames: move function to pull remotenames from the remoterepo to core

2017-10-12 Thread dlax (Denis Laxalde)
dlax added inline comments. INLINE COMMENTS > ryanmce wrote in remotenames.py:11-16 > nit: for multiline docblocks, I prefer to leave the first line empty: > > """ > pulls bookmarks and branches information of the remote repo during a > pull or clone operation. > > localrepo is our

D937: remotenames: move function to pull remotenames from the remoterepo to core

2017-10-12 Thread ryanmce (Ryan McElroy)
ryanmce requested changes to this revision. ryanmce added inline comments. INLINE COMMENTS > remotenames.py:10 > + > +def pullremotenames(localrepo, remoterepo, remotepath): > +""" pulls bookmarks and branches information of the remote repo during a It might be better to call this

D937: remotenames: move function to pull remotenames from the remoterepo to core

2017-10-05 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D937#15824, @dlax wrote: > Also, it'd be useful to indicate where the code comes from (i.e. what is the "remoterepo" mentioned in the first line of the commit message). Yeah sure I will add that in next version. >

D937: remotenames: move function to pull remotenames from the remoterepo to core

2017-10-05 Thread dlax (Denis Laxalde)
dlax added a comment. Also, it'd be useful to indicate where the code comes from (i.e. what is the "remoterepo" mentioned in the first line of the commit message). Then, a module docstring explaining the concept at stake (starting by what is a "remotename") and the purpose of the

D937: remotenames: move function to pull remotenames from the remoterepo to core

2017-10-05 Thread dlax (Denis Laxalde)
dlax requested changes to this revision. dlax added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > remotenames.py:28 > +if node in repo and not repo[node].obsolete(): > +bmap[branch].append(node) I don't get the point of the

D937: remotenames: move function to pull remotenames from the remoterepo to core

2017-10-04 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch moves the functionality to pull branches and bookmarks from a server from which we are pulling to core. The function used to exist in remotenames