D964: python3: add and use adapter for func_name attr, now known as __name__

2017-10-08 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG68faf082bdcd: python3: add and use adapter for func_name attr, now known as __name__ (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D964: python3: add and use adapter for func_name attr, now known as __name__

2017-10-06 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. Can't we just use `func.__name__` on both Pythons? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D964 To: durin42, #hg-reviewers, pulkit, indygreg,

D964: python3: add and use adapter for func_name attr, now known as __name__

2017-10-06 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Such a brittle pattern. It feels like the names of things should be defined in a decorator or something. But fixing this would be scope bloat and can be punted to another time.

D964: python3: add and use adapter for func_name attr, now known as __name__

2017-10-05 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D964 AFFECTED FILES mercurial/peer.py mercurial/pycompat.py mercurial/templater.py CHANGE DETAILS