This revision was automatically updated to reflect the committed changes.
Closed by commit rHG71e63fe6b1ab: py3: handle keyword arguments correctly in
hgext/patchbomb.py (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
yuja accepted this revision.
yuja added a comment.
This revision is now accepted and ready to land.
Queued this, thanks.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D974
To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
pulkit updated this revision to Diff 3376.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D974?vs=3231=3376
REVISION DETAIL
https://phab.mercurial-scm.org/D974
AFFECTED FILES
hgext/patchbomb.py
CHANGE DETAILS
diff --git a/hgext/patchbomb.py
yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> yuja wrote in patchbomb.py:618
> opts is modified here, but stropts isn't. Perhaps we shouldn't
> keep the copy for long.
I think it's better to use a single
pulkit updated this revision to Diff 3231.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D974?vs=2497=3231
REVISION DETAIL
https://phab.mercurial-scm.org/D974
AFFECTED FILES
hgext/patchbomb.py
CHANGE DETAILS
diff --git a/hgext/patchbomb.py
pulkit abandoned this revision.
pulkit added a comment.
Will revisit after the freeze.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D974
To: pulkit, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
___
Mercurial-devel
pulkit added a comment.
In https://phab.mercurial-scm.org/D974#16430, @yuja wrote:
> and missing import of pycompat. Please make sure all tests pass.
Oops, sorry. I am not sure ow this one slipped in without passing tests. I
will be more careful from now.
REPOSITORY
rHG
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
and missing import of pycompat. Please make sure all tests pass.
INLINE COMMENTS
> patchbomb.py:618
> if bundle:
> opts['revs'] = [str(r) for r in revs]
>
opts is
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The keys of keyword arguments must be str on Python 3 which is unicode. This
patch make sure we pass keyword arguments with keys are str everywhere in this
file
