Re: Hardlinks and Docker

2017-03-29 Thread Jun Wu
Excerpts from Gregory Szorc's message of 2017-03-29 18:15:43 -0700: > > So the direct fix is to stat the directory instead of the file. I will send > > it soon. > > Thank you for looking into this complicated issue! I'm glad I don't have > to review your code because this is all over my head at

Re: Hardlinks and Docker

2017-03-29 Thread Gregory Szorc
> On Mar 25, 2017, at 13:47, Jun Wu wrote: > > Excerpts from Jun Wu's message of 2017-03-25 12:19:46 -0700: >> Excerpts from Gregory Szorc's message of 2017-03-25 10:54:10 -0700: >>> Jun, et al: >>> >>> The recent patches around hardlink detection are great! However, there are

Re: Hardlinks and Docker

2017-03-25 Thread Jun Wu
Excerpts from Jun Wu's message of 2017-03-25 12:19:46 -0700: > Excerpts from Gregory Szorc's message of 2017-03-25 10:54:10 -0700: > > Jun, et al: > > > > The recent patches around hardlink detection are great! However, there are > > still some failures executing tests in certain Docker

Re: Hardlinks and Docker

2017-03-25 Thread Jun Wu
Excerpts from Gregory Szorc's message of 2017-03-25 10:54:10 -0700: > Jun, et al: > > The recent patches around hardlink detection are great! However, there are > still some failures executing tests in certain Docker configurations, such > as when using the overlay2 storage driver (overlayfs). >

Hardlinks and Docker

2017-03-25 Thread Gregory Szorc
Jun, et al: The recent patches around hardlink detection are great! However, there are still some failures executing tests in certain Docker configurations, such as when using the overlay2 storage driver (overlayfs). --- /mnt/hg/tests/test-hardlinks.t +++ /mnt/hg/tests/test-hardlinks.t.err @@