Re: [PATCH] revlog: ensure that flags do not overflow 2 bytes

2016-11-26 Thread Yuya Nishihara
On Fri, 25 Nov 2016 19:16:23 +, Jun Wu wrote: > Excerpts from Gregory Szorc's message of 2016-11-25 10:59:42 -0800: > > I think having the check in offset_type() to catch all consumers is the > > right place. (Another source of the flag is changegroup data via > > revlog.addgroup() and cg.delta

Re: [PATCH] revlog: ensure that flags do not overflow 2 bytes

2016-11-25 Thread Jun Wu
> > find it more appropriate. > > > > > > > > *From: *Gregory Szorc > > *Date: *Friday, November 25, 2016 at 5:27 PM > > *To: *Cotizo Sima > > *Subject: *Re: [PATCH] revlog: ensure that flags do not overflow 2 bytes > > > > > > >

Re: [PATCH] revlog: ensure that flags do not overflow 2 bytes

2016-11-25 Thread Gregory Szorc
t; *From: *Gregory Szorc > *Date: *Friday, November 25, 2016 at 5:27 PM > *To: *Cotizo Sima > *Cc: *mercurial-devel > *Subject: *Re: [PATCH] revlog: ensure that flags do not overflow 2 bytes > > > > On Fri, Nov 25, 2016 at 5:24 AM, Cotizo Sima wrote: > > # HG changeset patc

Re: [PATCH] revlog: ensure that flags do not overflow 2 bytes

2016-11-25 Thread Cotizo Sima
appropriate. From: Gregory Szorc Date: Friday, November 25, 2016 at 5:27 PM To: Cotizo Sima Cc: mercurial-devel Subject: Re: [PATCH] revlog: ensure that flags do not overflow 2 bytes On Fri, Nov 25, 2016 at 5:24 AM, Cotizo Sima mailto:cot...@fb.com>> wrote: # HG changeset patch # User

Re: [PATCH] revlog: ensure that flags do not overflow 2 bytes

2016-11-25 Thread Gregory Szorc
On Fri, Nov 25, 2016 at 5:24 AM, Cotizo Sima wrote: > # HG changeset patch > # User Cotizo Sima > # Date 1480079985 28800 > # Fri Nov 25 05:19:45 2016 -0800 > # Node ID 4b311b730614941db6409f560ab9451bec74be75 > # Parent a3163433647108b7bec8fc45896db1c20b18ab21 > revlog: ensure that flags