Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-04-13 Thread Yuya Nishihara
On Fri, 13 Apr 2018 19:56:21 +0200, Feld Boris wrote: > > We love the 'revset(EXPR)' idea and we have a v4 series that is ready > > to send. Can you mark it as "(EXPERIMENTAL)" in case we find a better way to work around the problem? > By re-reading your comments on the V3 series, I realized

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-04-13 Thread Feld Boris
On 13/04/2018 15:48, Feld Boris wrote: On 12/04/2018 13:09, Yuya Nishihara wrote: On Thu, 12 Apr 2018 11:32:23 +0200, Feld Boris wrote: On 11/04/2018 17:16, Yuya Nishihara wrote: On Wed, 11 Apr 2018 11:36:05 +0200, Feld Boris wrote: The proposal here is to define a prefix for which we break

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-04-13 Thread Feld Boris
On 12/04/2018 13:09, Yuya Nishihara wrote: On Thu, 12 Apr 2018 11:32:23 +0200, Feld Boris wrote: On 11/04/2018 17:16, Yuya Nishihara wrote: On Wed, 11 Apr 2018 11:36:05 +0200, Feld Boris wrote: The proposal here is to define a prefix for which we break backward compatibility. If we do so,

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-04-12 Thread Yuya Nishihara
On Thu, 12 Apr 2018 11:32:23 +0200, Feld Boris wrote: > On 11/04/2018 17:16, Yuya Nishihara wrote: > > On Wed, 11 Apr 2018 11:36:05 +0200, Feld Boris wrote: > The proposal here is to define a prefix for which we break backward > compatibility. If we do so, people with a "" label will

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-04-12 Thread Feld Boris
On 11/04/2018 17:16, Yuya Nishihara wrote: On Wed, 11 Apr 2018 11:36:05 +0200, Feld Boris wrote: The proposal here is to define a prefix for which we break backward compatibility. If we do so, people with a "" label will have to use:   "":whatever to get a similar effect. IIRC x:y was the

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-04-11 Thread Yuya Nishihara
On Wed, 11 Apr 2018 11:36:05 +0200, Feld Boris wrote: > >> The proposal here is to define a prefix for which we break backward > >> compatibility. If we do so, people with a "" label will have to use: > >> > >>   "":whatever > >> > >> to get a similar effect. > > IIRC x:y was the most important

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-04-11 Thread Feld Boris
On 02/03/2018 05:58, Yuya Nishihara wrote: On Thu, 1 Mar 2018 15:48:47 -0500, Feld Boris wrote: On 26/02/2018 08:11, Yuya Nishihara wrote: On Mon, 26 Feb 2018 11:45:03 +0100, Feld Boris wrote: On 13/02/2018 12:47, Yuya Nishihara wrote: On Mon, 12 Feb 2018 18:00:52 +0100, Boris Feld wrote: #

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-03-01 Thread Yuya Nishihara
On Thu, 1 Mar 2018 15:48:47 -0500, Feld Boris wrote: > On 26/02/2018 08:11, Yuya Nishihara wrote: > > On Mon, 26 Feb 2018 11:45:03 +0100, Feld Boris wrote: > >> On 13/02/2018 12:47, Yuya Nishihara wrote: > >>> On Mon, 12 Feb 2018 18:00:52 +0100, Boris Feld wrote: > # HG changeset patch >

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-03-01 Thread Feld Boris
On 26/02/2018 08:11, Yuya Nishihara wrote: On Mon, 26 Feb 2018 11:45:03 +0100, Feld Boris wrote: On 13/02/2018 12:47, Yuya Nishihara wrote: On Mon, 12 Feb 2018 18:00:52 +0100, Boris Feld wrote: # HG changeset patch # User Boris Feld # Date 1518448909 -3600 # Mon

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-02-27 Thread Matt Harbison
On Mon, 26 Feb 2018 05:45:03 -0500, Feld Boris wrote: On 13/02/2018 12:47, Yuya Nishihara wrote: On Mon, 12 Feb 2018 18:00:52 +0100, Boris Feld wrote: # HG changeset patch # User Boris Feld # Date 1518448909 -3600 # Mon Feb 12 16:21:49

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-02-27 Thread Yuya Nishihara
On Mon, 26 Feb 2018 21:42:01 -0500, Matt Harbison wrote: > On Mon, 26 Feb 2018 05:45:03 -0500, Feld Boris > wrote: > > On 13/02/2018 12:47, Yuya Nishihara wrote: > >> On Mon, 12 Feb 2018 18:00:52 +0100, Boris Feld wrote: > >>> # HG changeset patch > >>> # User Boris Feld

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-02-26 Thread Yuya Nishihara
On Mon, 26 Feb 2018 11:45:03 +0100, Feld Boris wrote: > On 13/02/2018 12:47, Yuya Nishihara wrote: > > On Mon, 12 Feb 2018 18:00:52 +0100, Boris Feld wrote: > >> # HG changeset patch > >> # User Boris Feld > >> # Date 1518448909 -3600 > >> # Mon Feb 12 16:21:49 2018

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-02-26 Thread Feld Boris
On 13/02/2018 12:47, Yuya Nishihara wrote: On Mon, 12 Feb 2018 18:00:52 +0100, Boris Feld wrote: # HG changeset patch # User Boris Feld # Date 1518448909 -3600 # Mon Feb 12 16:21:49 2018 +0100 # Node ID b0f45e1376e2d0f32023e197c51802bc21c60490 # Parent

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-02-13 Thread Yuya Nishihara
On Mon, 12 Feb 2018 18:00:52 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1518448909 -3600 > # Mon Feb 12 16:21:49 2018 +0100 > # Node ID b0f45e1376e2d0f32023e197c51802bc21c60490 > # Parent f02fd7ca256d044c4a51c3f3fc0ecaf95d23e03d > #