Re: [PATCH 8 of 8] revset: introduce an API that avoids `formatspec` input serialization

2019-01-14 Thread Boris FELD
On 13/01/2019 10:53, Yuya Nishihara wrote: > On Sun, 13 Jan 2019 08:40:41 +0100, Boris FELD wrote: >> On 12/01/2019 06:00, Yuya Nishihara wrote: >>> On Fri, 11 Jan 2019 12:29:10 +0100, Boris Feld wrote: # HG changeset patch # User Boris Feld # Date 1546605681 -3600 # Fri

Re: [PATCH 8 of 8] revset: introduce an API that avoids `formatspec` input serialization

2019-01-13 Thread Yuya Nishihara
On Sun, 13 Jan 2019 18:53:13 +0900, Yuya Nishihara wrote: > So here we have string to parse, b''.join(ret), and replacements, inputs. > If b''.join(ret) contained '$0' instead of 'internal(0)', and if inputs > were dict of {'$0': alias('$0', ..., ('smartset', inputs[0]))}, we can just > feed them

Re: [PATCH 8 of 8] revset: introduce an API that avoids `formatspec` input serialization

2019-01-13 Thread Yuya Nishihara
On Sun, 13 Jan 2019 08:40:41 +0100, Boris FELD wrote: > On 12/01/2019 06:00, Yuya Nishihara wrote: > > On Fri, 11 Jan 2019 12:29:10 +0100, Boris Feld wrote: > >> # HG changeset patch > >> # User Boris Feld > >> # Date 1546605681 -3600 > >> # Fri Jan 04 13:41:21 2019 +0100 > >> # Node ID

Re: [PATCH 8 of 8] revset: introduce an API that avoids `formatspec` input serialization

2019-01-12 Thread Boris FELD
On 12/01/2019 06:00, Yuya Nishihara wrote: > On Fri, 11 Jan 2019 12:29:10 +0100, Boris Feld wrote: >> # HG changeset patch >> # User Boris Feld >> # Date 1546605681 -3600 >> # Fri Jan 04 13:41:21 2019 +0100 >> # Node ID 73926c4ab24d6c01723ed050601b134bdc89562f >> # Parent

Re: [PATCH 8 of 8] revset: introduce an API that avoids `formatspec` input serialization

2019-01-11 Thread Yuya Nishihara
On Fri, 11 Jan 2019 12:29:10 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1546605681 -3600 > # Fri Jan 04 13:41:21 2019 +0100 > # Node ID 73926c4ab24d6c01723ed050601b134bdc89562f > # Parent 4a56fbdacff33c3985bbb84f2e19ddfbd48ed4fa > # EXP-Topic