> > (a) it's an extension which isn't on by default
> > (b) your font choices are your own. That doesn't look like any default
> font I've ever seen, so this is unlikely to affect many others
>
> Off topic. But there are many CJK fonts that you probably haven't seen.
> People using them
johnstiles (John Stiles) writes:
> johnstiles added a comment.
>
>
> In https://phab.mercurial-scm.org/D3665#58828, @smf wrote:
>
> > I've looked this over today and have queued this up :-) Unfortunately,
> though, the metadata doesn't seem right? I'm not getting your name or email
>
johnstiles (John Stiles) writes:
> johnstiles added a comment.
>
>
> I have put together an album of various fonts from my discussions with
> @yuja earlier in the thread: https://imgur.com/a/xFkj4zv
>
> I'm a Menlo or DejaVu guy myself.
Ah, I only just now realized each image had the
johnstiles (John Stiles) writes:
> johnstiles added a comment.
>
>
> Side note: I'm unfamiliar with the lingo here, what's +0 on a feature?
> Indifference?
Ah, yeah, sorry. To me, at least, it's a "sure but I don't want to be
blamed if it fails" ;-P (basically, "I won't block this"). Maybe
johnstiles (John Stiles) writes:
> johnstiles added a comment.
>
>
> It all depends on your terminal font. It looks like the font you're using
> now has issues with U+2506 ┆ and is otherwise working as expected.
Yeah, that was my fault. I forgot I had a different font for unicode
symbols to
> A proper warning is now issued when the encoding is not UTF-8, or when
> East-Asian ambiguous characters will be rendered as wide characters.
> The tests have been updated to check these warnings.
> Yuya, I believe this should address everything we discussed. Let me know if
> you see a
johnstiles (John Stiles) writes:
> johnstiles added a comment.
>
>
> In https://phab.mercurial-scm.org/D3665#57649, @smf wrote:
>
> > johnstiles (John Stiles) writes:
> >
> > > johnstiles added a comment.
> > >
> > > yuya, I believe these patches should address all of your
johnstiles (John Stiles) writes:
> johnstiles added a comment.
>
>
> yuya, I believe these patches should address all of your concerns except
> for `encoding._wide`. I am not sure what your expectation is for that. I
> don't think it would make sense to silently disable the extension if
>
> except for `encoding._wide`. I am not sure what your expectation is for that.
> I don't think it would make sense to silently disable the extension if
> `encoding._wide` is set; IMO that would cause user confusion.
I think that's also true for `encoding != 'UTF-8'`. The simplest solution
would
> This extension beautifies log -G output by using Unicode characters.
>
> A terminal with UTF-8 support and a monospace Unicode font are required.
First, I'm not sure if we'll want to maintain this extension in core since
unicode generally sucks.
That said, can you fix style nits
10 matches
Mail list logo
