> > Does the class name actually matter? Personally I don't care if
> > lazyancestors() function returns a LazyAncestors object. We'll anyway
> > need a wrapper function to make pure ancestors and rustext ancestors
> > compatible.
>
> Yes, that's in line with your other comments,
> +/// The purpose of this module is to hide identifiers from other Rust users
> +///
> +/// Some of the identifiers we are defining are meant for consumption
> +/// from Python with other naming conventions. For instance, `py_class!`
> +/// does not let us make a distinction between the Python
> m.add_class::(py)?;
> +m.add_class::(py)?;
Nit: While it's correct per our naming convention, I prefer calling it
as `LazyAncestors` in Rust, and export as `lazyancestors`.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
