Re: D6207: branchcache: add functions to validate changelog nodes

2019-04-16 Thread Yuya Nishihara
> The motivation behind iteritems() change > (https://phab.mercurial-scm.org/D6236) is optimizing > https://www.mercurial-scm.org/repo/hg-committed/file/70b71421fd33/mercurial/commands.py#l1128. Okay, got that, thanks. > Maybe we can iterate over verified nodes first, and then iterate over

Re: D6207: branchcache: add functions to validate changelog nodes

2019-04-15 Thread Yuya Nishihara
Queued, thanks. > +def _verifybranch(self, branch): > +""" verify head nodes for the given branch. If branch is None, verify > +for all the branches """ "If branch is None, ..." appears wrong. > +if branch not in self._entries or branch in self._verifiedbranches: > +