Re: [PATCH 2 of 8] py3: add os.fsdecode() as pycompat.fsdecode()

On Sun, 6 Nov 2016 04:57:40 -0500, timeless wrote: > Pulkit Goyal wrote: > > +# In Python 2, fsdecode() have a very chances to recieve bytes. So it's > > receive Fixed as: # In Python 2, fsdecode() has a very chance to receive bytes. So it's # better not to touch Python 2 part as

Re: [PATCH 08 of 10] repair: migrate revlogs during upgrade

Gregory Szorc wrote: > +return changelog.changelog(repo.svfs) > +elif path.endswith('00manifest.i'): Does mercurial use `else` after `return` or does it omit them? > + store replacement complete; repository was inconsistent for 0.0s Do we want to allow tests to run a bit slower

Re: [PATCH 2 of 2] commands: introduce `hg display`

Gregory Szorc wrote: > @@ -2019,6 +2026,13 @@ Dish up an empty repo; serve it cold. >diff repository (or selected files) > > > + > + display > + > + > + show various repository information > + > + > >export > Will /help/display list the views it supports?

Re: [PATCH 05 of 10] repair: obtain and validate requirements for upgraded repo

Gregory Szorc wrote: > +'missing: %s') % ', '.join(sorted(missingreqs))) I'd argue ', ' should be _(', '), although we probably don't manage this well or consistently... Also, is it too early to start talking about -T support? -- See `hg debuginstall`...

Re: [PATCH] help: show help for disabled extensions(issue5228)

On Sun, 6 Nov 2016 04:57:03 -0500, timeless wrote: > Pulkit Goyal wrote: > > This patch does not exactly solve issue5228 but it results in a better > > If it doesn't solve the issue, should the issue be tagged in the commit > summary? I think this fix is enough to say issue5228 is solved.

[PATCH 2 of 2] bdiff: don't check border condition in loop

# HG changeset patch # User Gregory Szorc # Date 1478417870 25200 # Sun Nov 06 00:37:50 2016 -0700 # Node ID 430a4c8f9fa6992afa47d459d592f6c58e686be2 # Parent e65ef545a3dcb46fe0f1798e76ea17f9f9323452 bdiff: don't check border condition in loop `plast = a + len -

[PATCH 1 of 2] perf: add perfbdiff

# HG changeset patch # User Gregory Szorc # Date 1478414512 25200 # Sat Nov 05 23:41:52 2016 -0700 # Node ID e65ef545a3dcb46fe0f1798e76ea17f9f9323452 # Parent f01367faa792635ad2f7a6b175ae3252292b5121 perf: add perfbdiff bdiff shows up a lot in profiling. I think it

Re: [PATCH 1 of 5 rfc] tests: explore some bdiff cases

On Thu, 03 Nov 2016 22:34:11 +0100, Mads Kiilerich wrote: > # HG changeset patch > # User Mads Kiilerich > # Date 1478208837 -3600 > # Thu Nov 03 22:33:57 2016 +0100 > # Node ID f6408efe0d0f4179fe6cc2b967164c1b4567f3d6 > # Parent d06c049695e6ad3219e7479c65ce98a2f123e878

Re: [PATCH V2] help: show help for disabled extensions(issue5228)

On Sun, 06 Nov 2016 09:10:18 +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1478395471 -19800 > # Sun Nov 06 06:54:31 2016 +0530 > # Node ID 6d27c42a7e01adcc0eabf88c623390c85c4a5943 > # Parent b5fc4e71286dd4f6e4f38e0b9fb17f51f1e3 >

Re: [PATCH] help: show help for disabled extensions(issue5228)

Pulkit Goyal wrote: > This patch does not exactly solve issue5228 but it results in a better If it doesn't solve the issue, should the issue be tagged in the commit summary? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

Re: [PATCH 04 of 10] repair: identify repository deficiencies

Gregory Szorc wrote: > A command that upgrades repositories but doesn't say what it is doing shouldn't it still mention that it isn't doing the work? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

Re: [PATCH 1 of 5 rfc] tests: explore some bdiff cases

On 11/06/2016 10:07 AM, Yuya Nishihara wrote: On Thu, 03 Nov 2016 22:34:11 +0100, Mads Kiilerich wrote: # HG changeset patch # User Mads Kiilerich # Date 1478208837 -3600 # Thu Nov 03 22:33:57 2016 +0100 # Node ID f6408efe0d0f4179fe6cc2b967164c1b4567f3d6 # Parent

Re: [PATCH 3 of 3] revlog: optimize _chunkraw when startrev==endrev

On 11/04/2016 09:27 AM, Yuya Nishihara wrote: On Tue, 01 Nov 2016 18:25:47 -0700, Gregory Szorc wrote: # HG changeset patch # User Gregory Szorc # Date 1477244433 25200 # Sun Oct 23 10:40:33 2016 -0700 # Node ID 4c96a177e4ff6a63156ec8cf49483a78e4437756 # Parent

Re: [PATCH 2 of 8] py3: add os.fsdecode() as pycompat.fsdecode()

Pulkit Goyal wrote: > +# In Python 2, fsdecode() have a very chances to recieve bytes. So it's receive ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

[Bug 5417] New: Cannot clone repo

https://bz.mercurial-scm.org/show_bug.cgi?id=5417 Bug ID: 5417 Summary: Cannot clone repo Product: Mercurial Version: 3.7.3 Hardware: PC OS: Linux Status: UNCONFIRMED Severity: feature Priority:

Re: [PATCH 1 of 2] perf: add perfbdiff

On 11/06/2016 08:42 AM, Gregory Szorc wrote: # HG changeset patch # User Gregory Szorc # Date 1478414512 25200 # Sat Nov 05 23:41:52 2016 -0700 # Node ID e65ef545a3dcb46fe0f1798e76ea17f9f9323452 # Parent f01367faa792635ad2f7a6b175ae3252292b5121 perf: add perfbdiff

Re: [PATCH 3 of 3] revlog: optimize _chunkraw when startrev==endrev

okay, I've fixed this in flight. On 11/06/2016 06:31 PM, Gregory Szorc wrote: On Sun, Nov 6, 2016 at 7:16 AM, Pierre-Yves David > wrote: On 11/04/2016 09:27 AM, Yuya Nishihara wrote: On Tue, 01 Nov 2016

Re: [PATCH STABLE V2] hgweb: cache fctx.parents() in annotate command (issue5414)

Excerpts from Yuya Nishihara's message of 2016-11-06 11:31:04 +0900: > Perhaps fctx.parents() can be property-cached, but we'll need to drop > uninteresting chains of parents in fctx.annotate(). If we go the property-cache approach, I think it's better to cache "_adjustedlinkrev". It's at a lower

[PATCH 1 of 3] perf: prepare to handle multiple pairs in perfbdiff

# HG changeset patch # User Gregory Szorc # Date 1478454674 28800 # Sun Nov 06 09:51:14 2016 -0800 # Node ID b8907ec6c08b8215ea8937ecd5f801006d433604 # Parent 38f7d48d4a8399dc14e95250697fc98bfeafb1fc perf: prepare to handle multiple pairs in perfbdiff Before, we

Re: [PATCH 2 of 5] adjustlinkrev: use C implementation to test ancestor if possible

On 11/02/2016 03:05 AM, Jun Wu wrote: Excerpts from Pierre-Yves David's message of 2016-11-02 00:29:45 +0100: On 11/01/2016 09:51 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1477989396 0 # Tue Nov 01 08:36:36 2016 + # Node ID

Re: [PATCH 2 of 2] bdiff: don't check border condition in loop

These two are pushed thanks. On 11/06/2016 08:42 AM, Gregory Szorc wrote: # HG changeset patch # User Gregory Szorc # Date 1478417870 25200 # Sun Nov 06 00:37:50 2016 -0700 # Node ID 430a4c8f9fa6992afa47d459d592f6c58e686be2 # Parent

Re: [PATCH 6 of 7] py3: use try/except to check for basestring

This https://www.mercurial-scm.org/pipermail/mercurial-devel/2016-October/089099.html is a better version of what I want to do, since this didn't went through I will be using this. On Fri, Nov 4, 2016 at 9:21 AM, Yuya Nishihara wrote: > On Thu, 03 Nov 2016 03:53:11 +0530, Pulkit

[PATCH 2 of 3] perf: support bdiffing multiple revisions in a single revlog

# HG changeset patch # User Gregory Szorc # Date 1478458885 28800 # Sun Nov 06 11:01:25 2016 -0800 # Node ID 91a510590fa6f4003f596bf661cb17da8800ecde # Parent b8907ec6c08b8215ea8937ecd5f801006d433604 perf: support bdiffing multiple revisions in a single revlog This

[PATCH 3 of 3] perf: support measuring bdiff for all changeset related data

# HG changeset patch # User Gregory Szorc # Date 1478458015 28800 # Sun Nov 06 10:46:55 2016 -0800 # Node ID 1c7269484883804b6f960e87309169ef4ae85043 # Parent 91a510590fa6f4003f596bf661cb17da8800ecde perf: support measuring bdiff for all changeset related data The

[PATCH] bdiff: replace hash algorithm

# HG changeset patch # User Gregory Szorc # Date 1478487117 28800 # Sun Nov 06 18:51:57 2016 -0800 # Node ID bb7c6d6f4a10e80ff4bdf88919692f08497d2d66 # Parent 1c7269484883804b6f960e87309169ef4ae85043 bdiff: replace hash algorithm This patch replaces lyhash with the

Re: to abort / to continue (UX)

On 11/04/2016 07:13 PM, timeless wrote: timeless wrote: technically this isn't wonderful, if you use bookmarks, `hg up -C .` isn't equivalent to `hg up -C {currentbookmark}`, and if you're using hg-git or something that puts significant weight on your active bookmark, this can lead you into