D230: http: add a test of actually pushing with httppostargs

2017-08-07 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG970967e0a917: http: add a test of actually pushing with httppostargs (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D230?vs=558=620

D241: context: rename bumped into phasedivergent

2017-08-07 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > context.py:220 > +self._repo.ui.deprecwarn(msg, '4.4') > +return self.orphan() > + Shouldn't this be `self.phasedivergent()`? REPOSITORY

D240: context: rename divergent into contentdivergent

2017-08-07 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > context.py:227 > +self._repo.ui.deprecwarn(msg, '4.4') > +return self.orphan() > + This should be `self.contentdivergent()` no?

D267: httppeer: remove unused handler attribute

2017-08-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The consumer of this attribute was removed by https://phab.mercurial-scm.org/rHGb6bd4ee6ed85628b26d6cd7186b76624f40548bf in 2008. REPOSITORY rHG Mercurial

D266: localrepo: remove unused requirements attributes on localpeer (API)

2017-08-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The previous changeset removed the last consumer of requirements. I'm not sure when supportedformats became unused. But I couldn't find any obvious instances

D268: httppeer: make several instance attributes internal (API)

2017-08-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Peer instances are supposed to conform to a well-defined API so consumers can be agnostic about the underlying peer type. To reinforce this, this commit

D265: exchange: access requirements on repo instead of peer

2017-08-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of formalizing the peer interface, I audited for attribute accesses for non-internal names to find API violations. This uncovered the code changed in

D238: context: rename troubles into instabilities

2017-08-07 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > context.py:246-248 > +"""return the list of instabilities affecting this changeset. > + > +Instabilities are returned as strings. possible

D239: context: rename unstable into orphan

2017-08-07 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > context.py:208 > +msg = ("'context.unstable' is deprecated, " > + "use 'context.oprhan'") > +self._repo.ui.deprecwarn(msg, '4.4')

D264: exchange: drop support for lock-based unbundling (BC)

2017-08-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz accepted this revision as: martinvonz. martinvonz added a comment. Looks great to me. I also can't see this being a problem for anyone. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D264 To: indygreg, #hg-reviewers, martinvonz Cc: martinvonz,

D152: repo: skip invalidation of changelog if it has 'delayed' changes (API)

2017-08-07 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 619. martinvonz marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D152?vs=321=619 REVISION DETAIL https://phab.mercurial-scm.org/D152 AFFECTED FILES mercurial/localrepo.py

Re: [PATCH] contrib: add check for use of admonitions and its validity

2017-08-07 Thread Augie Fackler
On Sat, Aug 05, 2017 at 10:36:46PM +0900, Yuya Nishihara wrote: > On Sat, 05 Aug 2017 08:54:13 +0530, Rishabh Madan wrote: > > # HG changeset patch > > # User Rishabh Madan > > # Date 1501903168 -19800 > > # Sat Aug 05 08:49:28 2017 +0530 > > # Node ID

[Bug 5649] New: gpg should handle revoked keys more gracefully

2017-08-07 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5649 Bug ID: 5649 Summary: gpg should handle revoked keys more gracefully Product: Mercurial Version: 4.1.3 Hardware: PC OS: Other Status: UNCONFIRMED

D260: chg: define _GNU_SOURCE to allow CentOS 5 compilation

2017-08-07 Thread Mathias De Maré
Mathiasdm created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D260 AFFECTED FILES contrib/chg/Makefile CHANGE DETAILS diff --git a/contrib/chg/Makefile

D260: chg: define _GNU_SOURCE to allow CentOS 5 compilation

2017-08-07 Thread Mathias De Maré
Mathiasdm reclaimed this revision. Mathiasdm added a comment. Alright, it appears this does not work like I expected... REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D260 To: Mathiasdm, #hg-reviewers Cc: mercurial-devel

D261: centos5: use vault urls

2017-08-07 Thread Mathias De Maré
Mathiasdm created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY CentOS 5 has reached end-of-life. A working build for it is still possible using 'vault.centos.org'. REPOSITORY rHG Mercurial REVISION DETAIL

D260: chg: define _GNU_SOURCE to allow CentOS 5 compilation

2017-08-07 Thread Mathias De Maré
Mathiasdm abandoned this revision. Mathiasdm added a comment. My mistake, I meant to send 2 changesets and forgot to modify the revset. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D260 To: Mathiasdm, #hg-reviewers Cc: mercurial-devel

D240: context: rename divergent into contentdivergent

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Rename divergent context method into contentdivergent and add a deprecation warning on divergent. Only update all callers to keep the patch

D239: context: rename unstable into orphan

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Rename unstable context method into orphan and add a deprecation warning on unstable. Only update all callers to keep the patch straightforward. The

D241: context: rename bumped into phasedivergent

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Rename bumped context method into phasedivergent and add a deprecation warning on bumped. Only update all callers to keep the patch straightforward.

D216: evolution: rename bumped to phase-divergent

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 581. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D216?vs=561=581 REVISION DETAIL https://phab.mercurial-scm.org/D216 AFFECTED FILES mercurial/commands.py mercurial/context.py mercurial/exchange.py

D215: evolution: rename divergent to content-divergent

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 580. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D215?vs=560=580 REVISION DETAIL https://phab.mercurial-scm.org/D215 AFFECTED FILES mercurial/commands.py mercurial/context.py mercurial/exchange.py

D214: evolution: rename unstable to orphan

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 579. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D214?vs=505=579 REVISION DETAIL https://phab.mercurial-scm.org/D214 AFFECTED FILES mercurial/commands.py mercurial/context.py mercurial/exchange.py

D247: obsutil: rename allprecursors into allpredecessors

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Use util.nouideprecwarn because obsstore doesn't have easy access to an ui object. The renaming is done according to

D244: obsolete: rename _addprecursors into _addpredecessors

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Use util.nouideprecwarn because _addpredecessors doesn't have easy access to an ui object. The renaming is done according to

D238: context: rename troubles into instabilities

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Rename troubles context method into instabilities. Copy the old troubles method and add a deprecation warning. This way extensions calling troubles will

D242: context: rename troubled into isunstable

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As we changed the meaning of unstable between the old vocabulary and the new one, we can't reuse the unstable method name at the risk of breaking extensions

D246: obsolete: rename precursor into predecessor in obsolete docstrings

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The renaming is done according to https://www.mercurial-scm.org/wiki/CEDVocabulary. REPOSITORY rHG Mercurial REVISION DETAIL

D245: obsstore: rename precursors into predecessors

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Use util.nouideprecwarn because obsstore doesn't have easy access to an ui object. The renaming is done according to

D243: obsmarker: rename precnode into prednode

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Rename prednode (predecessors node) into precnode (precursors node) in markers class. Use util.nouideprecwarn because markers doesn't have easy access to an

D259: label: rename log.trouble into log.instability

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan added a reviewer: quark. lothiraldan added a subscriber: quark. lothiraldan added a comment. Here are hopefully the last patches of this series. @quark I tried running the hg-experimental (https://bitbucket.org/facebook/hg-experimental) tests against this series. I think

[PATCH 4 of 8] template: add minimal obsfate template function

2017-08-07 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1501850856 -7200 # Fri Aug 04 14:47:36 2017 +0200 # Node ID a96edc5bcdc8790719e003eefff91a4f656cc559 # Parent e3f0339b83553039dcd87b62dc1dfbdf98548792 # EXP-Topic obsfatetemplate template: add minimal obsfate template

[PATCH 1 of 8] obsolete: introduce a _succs class

2017-08-07 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1499036035 -7200 # Mon Jul 03 00:53:55 2017 +0200 # Node ID a3797b722e73a1390d0dc8cb4c4630e4fe177919 # Parent 50c44dee741ab99401bf0b3446fe4ae88ccd0bb2 # EXP-Topic obsfatetemplate obsolete: introduce a _succs class It

[PATCH 7 of 8] template: compute dates in obsfate

2017-08-07 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1499088850 -7200 # Mon Jul 03 15:34:10 2017 +0200 # Node ID 274933e813ada051cba2e0d193ad098d0d0b28b6 # Parent d20670d9a7ed76321fbeed7605ceaea1200f9625 # EXP-Topic obsfatetemplate template: compute dates in obsfate

[PATCH 2 of 8] obsolete: add an explicit '_succs.copy()' method

2017-08-07 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1499044397 -7200 # Mon Jul 03 03:13:17 2017 +0200 # Node ID be13b5fb2782b04b03d60a988ba306ba4a8d80bd # Parent a3797b722e73a1390d0dc8cb4c4630e4fe177919 # EXP-Topic obsfatetemplate obsolete: add an explicit '_succs.copy()'

[PATCH 5 of 8] template: compute verb in obsfate

2017-08-07 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1499088807 -7200 # Mon Jul 03 15:33:27 2017 +0200 # Node ID 5b38b7216fe07a3a2ff5f1f6b3dfbe4dc986fac9 # Parent a96edc5bcdc8790719e003eefff91a4f656cc559 # EXP-Topic obsfatetemplate template: compute verb in obsfate Use the

[PATCH 3 of 8] obsolete: track markers in _succs

2017-08-07 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1499045278 -7200 # Mon Jul 03 03:27:58 2017 +0200 # Node ID e3f0339b83553039dcd87b62dc1dfbdf98548792 # Parent be13b5fb2782b04b03d60a988ba306ba4a8d80bd # EXP-Topic obsfatetemplate obsolete: track markers in _succs We now

[PATCH 6 of 8] template: compute user in obsfate

2017-08-07 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1499088840 -7200 # Mon Jul 03 15:34:00 2017 +0200 # Node ID d20670d9a7ed76321fbeed7605ceaea1200f9625 # Parent 5b38b7216fe07a3a2ff5f1f6b3dfbe4dc986fac9 # EXP-Topic obsfatetemplate template: compute user in obsfate

[PATCH 8 of 8] template: better prune support in obsfate

2017-08-07 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1499096336 -7200 # Mon Jul 03 17:38:56 2017 +0200 # Node ID 1d6509b36d5e03608e160c0c0453c129a373dacd # Parent 274933e813ada051cba2e0d193ad098d0d0b28b6 # EXP-Topic obsfatetemplate template: better prune support in obsfate

Re: [PATCH] filemerge: move decorator definition for internal merge tools to registrar

2017-08-07 Thread Yuya Nishihara
On Mon, 07 Aug 2017 00:20:36 +0900, FUJIWARA Katsunori wrote: > At Sun, 6 Aug 2017 22:16:04 +0900, > Yuya Nishihara wrote: > > On Sun, 06 Aug 2017 03:51:49 +0900, FUJIWARA Katsunori wrote: > > > # HG changeset patch > > > # User FUJIWARA Katsunori > > > # Date 1501949637

D254: obsolete: rename divergent volatile set into contentdivergent volatile set

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The renaming is done according to https://www.mercurial-scm.org/wiki/CEDVocabulary. REPOSITORY rHG Mercurial REVISION DETAIL

D252: revset: rename bumped into phasedivergent

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Don't touch bumped volatile set name, only the revset name. The volatile set name will be updated in a later patch. The renaming is done according to

D253: obsolete: rename unstable volatile set into orphan volatile set

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The renaming is done according to https://www.mercurial-scm.org/wiki/CEDVocabulary. REPOSITORY rHG Mercurial REVISION DETAIL

D251: revset: remane divergent into contentdivergent

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Don't touch divergent volatile set name, only the revset name. The volatile set name will be updated in a later patch. The renaming is done according to

D258: label: rename trouble.X into instability.X

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The renaming is done according to https://www.mercurial-scm.org/wiki/CEDVocabulary. REPOSITORY rHG Mercurial REVISION DETAIL

D255: obsolete: rename bumped volatile set into phasedivergent volatile set

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The renaming is done according to https://www.mercurial-scm.org/wiki/CEDVocabulary. REPOSITORY rHG Mercurial REVISION DETAIL

D256: test: add a test for stabilization related labels

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D256 AFFECTED FILES tests/test-obsolete.t CHANGE DETAILS diff --git a/tests/test-obsolete.t

D257: label: rename changeset.troubled into changeset.unstable

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The renaming is done according to https://www.mercurial-scm.org/wiki/CEDVocabulary. REPOSITORY rHG Mercurial REVISION DETAIL

D259: label: rename log.trouble into log.instability

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The renaming is done according to https://www.mercurial-scm.org/wiki/CEDVocabulary. REPOSITORY rHG Mercurial REVISION DETAIL

D237: template: rename troubles templatekw into instabilities

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Rename troubles template keyword into instabilities and add a deprecation warning on templatekw. Update default mapfile and test files to use the new

D213: evolution: rename trouble(s) to instability

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 578. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D213?vs=504=578 REVISION DETAIL https://phab.mercurial-scm.org/D213 AFFECTED FILES mercurial/cmdutil.py tests/test-commit-amend.t

D250: revset: rename unstable into orphan

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Don't touch unstable volatile set name, only the revset name. The volatile set name will be updated in a later patch. The renaming is done according to

D249: test: update evolution config

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY evolution* config has been rewritten in stabilization* in the previous patch, update tests file to use the new names. REPOSITORY rHG Mercurial REVISION

D248: config: rename evolution config into stabilization

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Use aliases for backward-compatibility. Though I'm not sure how to emit compatibility warnings with aliases. Test configuration are updated in the next

Re: [PATCH] filemerge: move decorator definition for internal merge tools to registrar

2017-08-07 Thread FUJIWARA Katsunori
At Tue, 8 Aug 2017 00:12:51 +0900, Yuya Nishihara wrote: > > On Mon, 07 Aug 2017 00:20:36 +0900, FUJIWARA Katsunori wrote: > > At Sun, 6 Aug 2017 22:16:04 +0900, > > Yuya Nishihara wrote: > > > On Sun, 06 Aug 2017 03:51:49 +0900, FUJIWARA Katsunori wrote: > > > > # HG changeset patch > > > > #

D260: chg: define _GNU_SOURCE to allow CentOS 5 compilation

2017-08-07 Thread quark (Jun Wu)
quark added a comment. Could you include the compiler error if `_GNU_SOURCE` is not set in commit message? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D260 To: Mathiasdm, #hg-reviewers Cc: quark, mercurial-devel

D259: label: rename log.trouble into log.instability

2017-08-07 Thread quark (Jun Wu)
quark added a comment. In https://phab.mercurial-scm.org/D259#4135, @lothiraldan wrote: > Here are hopefully the last patches of this series. > > @quark I tried running the hg-experimental (https://bitbucket.org/facebook/hg-experimental) tests against this series. > > I think I

D262: test-rebase: add a brute force test

2017-08-07 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Rebase is becoming more complex and it looks like a good idea to try some brute force enumeration to cover cases that are hard to find manually. Using brute

D261: centos5: use vault urls

2017-08-07 Thread quark (Jun Wu)
quark accepted this revision. quark added a comment. Looks good to me. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D261 To: Mathiasdm, #hg-reviewers, quark Cc: quark, mercurial-devel ___ Mercurial-devel mailing list

D262: test-rebase: add a brute force test

2017-08-07 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. Thanks for the patch, more testing is always good. I'm wondering if we could use hypothesis (https://github.com/HypothesisWorks/hypothesis-python) for more tests like that. One article I found interesting was:

D262: test-rebase: add a brute force test

2017-08-07 Thread quark (Jun Wu)
quark added a comment. While I think hypothesis might be somehow useful. It is to generate random test cases, which is different from the efficient brute force here. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D262 To: quark, #hg-reviewers Cc: lothiraldan,