[PATCH 2 of 6 STABLE] amend: do not take untracked files as modified or clean (issue5732)

2017-11-08 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1509806759 -32400 # Sat Nov 04 23:45:59 2017 +0900 # Branch stable # Node ID bbdfaa3d4dc9ca3293065cfdaa611e95e6aa8cc6 # Parent a300140d16436606c8fd73f82dd7c8943de38240 amend: do not take untracked files as modified or clean

[PATCH 1 of 6 STABLE] tests: add more complete test for status changes on amend

2017-11-08 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1509806426 -32400 # Sat Nov 04 23:40:26 2017 +0900 # Branch stable # Node ID a300140d16436606c8fd73f82dd7c8943de38240 # Parent 4cc910cd81d04a9b29c48e0890e06047f21dd8fb tests: add more complete test for status changes on amend

[PATCH 6 of 6 STABLE] amend: update .hgsubstate before committing a memctx (issue5677)

2017-11-08 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1509793660 -32400 # Sat Nov 04 20:07:40 2017 +0900 # Branch stable # Node ID 17f13d94fbfb4f59bdae5e7a0deb04c3314a992e # Parent 34c95aad895f0a96e3becbdfec61a073fbe759f3 amend: update .hgsubstate before committing a memctx

[PATCH 4 of 6 STABLE] tests: demonstrate that .hgsubstate isn't updated on amend

2017-11-08 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1509789297 -32400 # Sat Nov 04 18:54:57 2017 +0900 # Branch stable # Node ID 4edd1c6048fac782a8606d8b8e22c24a6208de7a # Parent 53b507cba99d5fe71a5a018cba1c0ab67d64ce79 tests: demonstrate that .hgsubstate isn't updated on amend

[PATCH 3 of 6 STABLE] amend: do not drop missing files (issue5732)

2017-11-08 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1509806899 -32400 # Sat Nov 04 23:48:19 2017 +0900 # Branch stable # Node ID 53b507cba99d5fe71a5a018cba1c0ab67d64ce79 # Parent bbdfaa3d4dc9ca3293065cfdaa611e95e6aa8cc6 amend: do not drop missing files (issue5732) samefile()

[PATCH 5 of 6 STABLE] subrepo: extract preprocess of repo.commit() to free function

2017-11-08 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1509790899 -32400 # Sat Nov 04 19:21:39 2017 +0900 # Branch stable # Node ID 34c95aad895f0a96e3becbdfec61a073fbe759f3 # Parent 4edd1c6048fac782a8606d8b8e22c24a6208de7a subrepo: extract preprocess of repo.commit() to free

D1336: Summary: hg rm -A option prints the message of every file in the repo. This is not very user friendly for a big repository with thousands of files. So enabling this feature only when run in --v

2017-11-08 Thread pavanpc (Pavan Kumar PC)
pavanpc created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. TEST PLAN check if the message is printed in verbose mode. cd hg-crew/tests rt test-remove.t REPOSITORY rHG Mercurial REVISION DETAIL

D1270: help: adding a topic on flags

2017-11-08 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio added a comment. In https://phab.mercurial-scm.org/D1270#21058, @martinvonz wrote: > We're in code freeze for approximately two more days, so this will have to wait until ~Thursday. Still, thanks for the patch. I'm happy to include something like this. Things that struck me as

D1270: help: adding a topic on flags

2017-11-08 Thread rdamazio (Rodrigo Damazio Bovendorp)
rdamazio updated this revision to Diff 3334. rdamazio marked 4 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1270?vs=3168=3334 REVISION DETAIL https://phab.mercurial-scm.org/D1270 AFFECTED FILES contrib/wix/help.wxs

Re: Storage format for remotenames.

2017-11-08 Thread Yuya Nishihara
On Tue, 7 Nov 2017 09:58:04 -0800, Durham Goode wrote: > I wish we had some easily reusable serializer/deserializer instead of > having to reinvent these every time. What's our reasoning for not using > json? I forget. If there are some weird characters, like control > characters or something,

D1293: rebase: use fm.formatlist() and fm.formatdict() to support user template

2017-11-08 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D1293#21761, @yuja wrote: > Can you add a test that should be fixed by this patch? > Perhaps that will show we'll probably want to set the name of dict item pair > other than the default 'key'/'value'. Sorry but I am

D1344: dirstate: remove _droppath method

2017-11-08 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This method now doesn't do very much interesting and can be removed. The updated files set can be updated where _droppath was originally called. REPOSITORY

D1345: dirstate: add explicit methods for querying directories

2017-11-08 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The set-like object returned by dirstate.dirs may be difficult for other implementations of the dirstate to provide, and is unnecessary as it is only ever used

D1347: dirstate: make map implementation overridable

2017-11-08 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Other implementations of dirstate will want to replace the class used for the dirstate map. Allow this to happen by making the class an attribute of the

D1270: help: adding a topic on flags

2017-11-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > flags.txt:8 > +Additionally, some flags, such as --repository, are global and can be used > with > +any command - those are seen in :hg:`help -v`, and can be specified. > + The final "and can be specified" sounds a little truncated. Was there

D1342: dirstate: move management of the dirstate dirs into the dirstatemap

2017-11-08 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The dirstate dirs object is owned by the map, so move management of that object there. A future implementation of the dirstate will manage the dirs object

D1343: dirstate: move dropping of folded filenames into the dirstate map

2017-11-08 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When dropping files from the dirstate, the corresponding entry in the filefoldmap is also dropped. Move this into the dirstate map object. A future

D1338: dirstate: clear map cached properties when clearing the map

2017-11-08 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY dirstatemap.clear should remove all record of the files in the map. This includes removing caches of values derived from these. REPOSITORY rHG Mercurial

D1337: util: add util.clearcachedproperty

2017-11-08 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This utility function allows clearing of the cached value set up @propertycache, if there is one. REPOSITORY rHG Mercurial REVISION DETAIL

D1340: dirstate: add explicit methods for modifying dirstate

2017-11-08 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Instead of assigning dirstatetuple objects to entries in the dirstate, move responsibility for creating tuples into the dirstatemap. REPOSITORY rHG Mercurial

D1341: dirstate: move management of nonnormal sets into dirstate map

2017-11-08 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The dirstate map owns the nonnormal sets, and so should be the class to update them. A future implementation of the dirstate will manage these maps

D1339: dirstate: don't remove normallookup files from nonnormalset

2017-11-08 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The dirstate typically tries to keep the nonnormalset and otherparentset up-to-date when making changes to the dirstate. In the case of files marked

D1346: fsmonitor: only access inner dirstate map if it is available

2017-11-08 Thread mbthomas (Mark Thomas)
mbthomas created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of the dirstate refactor, fsmonitor was updated to directly access the inner map of the dirstatemap object. Dirstatemap reimplementations may not

D1348: histedit: add support to output nodechanges using formatter

2017-11-08 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The JSON output of nodechanges will help in automation and to improve editor integrations such as for Nuclide. REPOSITORY rHG

[PATCH] debugdeltachain: output information about sparse read if enabled

2017-11-08 Thread Paul Morelle
# HG changeset patch # User Paul Morelle # Date 1509002829 -7200 # Thu Oct 26 09:27:09 2017 +0200 # Node ID 13a6c881be35e7651a12f8c3442abfade2b77c88 # Parent 602c168c0207c443ac61f7a7c727b31cfb0b86ad # EXP-Topic debugdeltachain # Available At

[PATCH] debuglocks: allow setting a lock

2017-11-08 Thread Paul Morelle
# HG changeset patch # User Paul Morelle # Date 1510071568 -3600 # Tue Nov 07 17:19:28 2017 +0100 # Node ID 5300b33397d0651eb2457502204969585d492cc5 # Parent 602c168c0207c443ac61f7a7c727b31cfb0b86ad # EXP-Topic debugsetlocks # Available At

D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

2017-11-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. As the author of that line of code, this looks good to me. I'll let someone else queue it since I was involved in the internal discussion and I don't want to feel like I'm queuing my own code (even though I wasn't involved in the actual coding). REPOSITORY rHG

D1351: changegroup: use any node, not min(), in treemanifest's generatemanifests

2017-11-08 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is fixing quadratic behavior, which is probably not noticeable in the common case, but if a very large directory gets added here, it can get pretty bad.

D1336: HG: hg rm -A option prints the message of every file in the repo

2017-11-08 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. Thank you for the proposed change. Does --quiet work for you? I don't think I necessarily agree with the premise here. I think the only way every file in the repo is printed is if you delete every file first. Many file operations like add, remove/forget,

Re: Storage format for remotenames.

2017-11-08 Thread Gregory Szorc
> On Nov 8, 2017, at 06:00, Yuya Nishihara wrote: > >> On Tue, 7 Nov 2017 09:58:04 -0800, Durham Goode wrote: >> I wish we had some easily reusable serializer/deserializer instead of >> having to reinvent these every time. What's our reasoning for not using >> json? I forget.