D1667: tests_: fix test-lfs.t on OSX where find does not have quotes

2017-12-13 Thread ikostia (Kostia Balytskyi)
ikostia abandoned this revision. ikostia added a comment. @quark: thanks for the `tests` note. abandoning this as an equivalent change is already landed. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1667 To: ikostia, #hg-reviewers, quark, akushner Cc:

D1426: logtoprocess: add the possibility to not start a shell

2017-12-13 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. Without `DETACHED_PROCESS`, no console is spawned either with `shell=False` or `shell=True` **but** Mercurial will wait for the log-to-process script to finish before ending. So I would say to keep `DETACHED_PROCESS`. The real question is how to do

Re: That pesky windows run-tests failure on the buildbot

2017-12-13 Thread Feld Boris
On Wed, 2017-12-13 at 21:29 +0900, Yuya Nishihara wrote: > On Tue, 12 Dec 2017 18:13:24 -0500, Matt Harbison wrote: > > > On Dec 12, 2017, at 5:57 PM, Augie Fackler > > > wrote: > > > Finally, some useful output: > > > > > > +  --- $TESTTMP/anothertests/test-runtestdir.t > > >

Re: That pesky windows run-tests failure on the buildbot

2017-12-13 Thread Augie Fackler
> On Dec 13, 2017, at 08:14, Feld Boris wrote: > > On Wed, 2017-12-13 at 21:29 +0900, Yuya Nishihara wrote: >> On Tue, 12 Dec 2017 18:13:24 -0500, Matt Harbison wrote: On Dec 12, 2017, at 5:57 PM, Augie Fackler wrote: Finally, some useful

D1678: revset: pass pre-optimized tree in revset.matchany()

2017-12-13 Thread yuja (Yuya Nishihara)
yuja added a comment. In https://phab.mercurial-scm.org/D1678#28686, @pulkit wrote: > @yuja am I headed in the right direction? (I am not sure about whether the API's I changed are used by extensions or not) Sort of, but I was thinking of a simpler one. Just parse specs twice,

Re: [PATCH] lfs: add an experimental config to masquerade as git for the blob transfer

2017-12-13 Thread Augie Fackler
> On Dec 13, 2017, at 09:47, Matt Harbison wrote: > > > > On Dec 12, 2017, at 6:10 PM, Matt Harbison > wrote: > >> >>> On Dec 12, 2017, at 5:48 PM, Augie Fackler >> >

D1673: py3: handle keyword arguments correctly in hgext/record.py

2017-12-13 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG57cfc8f6d83e: py3: handle keyword arguments correctly in hgext/record.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1672: py3: handle keyword arguments correctly in bundlerepo.py

2017-12-13 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc549b997fbed: py3: handle keyword arguments correctly in bundlerepo.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1670: debugbuilddag: create filectx instance in 'filectxfn' callback

2017-12-13 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3efad47ea59f: debugbuilddag: create filectx instance in filectxfn callback (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1674: py3: pass bytes from extension to ui.write() in test-revlog-mmapindex.t

2017-12-13 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4786ad4b5d54: py3: pass bytes from extension to ui.write() in test-revlog-mmapindex.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1671: py3: handle keyword arguments correctly in debugcommands.py

2017-12-13 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc4d8920cfbaf: py3: handle keyword arguments correctly in debugcommands.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1675: py3: introduce pycompat.ziplist as zip is a generator on Python 3

2017-12-13 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa4f655d1161b: py3: introduce pycompat.ziplist as zip is a generator on Python 3 (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1669: synthrepo: create filectx instance in 'filectxfn' callback

2017-12-13 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG26064f261bbe: synthrepo: create filectx instance in filectxfn callback (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1426: logtoprocess: add the possibility to not start a shell

2017-12-13 Thread yuja (Yuya Nishihara)
yuja added a subscriber: mharbison72. yuja added a comment. In https://phab.mercurial-scm.org/D1426#28695, @lothiraldan wrote: > Without `DETACHED_PROCESS`, no console is spawned either with `shell=False` or `shell=True` **but** Mercurial will wait for the log-to-process script to

Re: [PATCH 1 of 2 V4] debuglocks: add tests (and fix typo in early return)

2017-12-13 Thread Yuya Nishihara
On Wed, 13 Dec 2017 01:58:05 +0100, Paul Morelle wrote: > # HG changeset patch > # User Paul Morelle > # Date 1510497259 -3600 > # Sun Nov 12 15:34:19 2017 +0100 > # Node ID 9beb49c91570014c034c3eaad9ce0a7a37e4c931 > # Parent

Re: [PATCH 2 of 2 V4] debuglocks: allow setting a lock

2017-12-13 Thread Yuya Nishihara
On Wed, 13 Dec 2017 01:58:06 +0100, Paul Morelle wrote: > # HG changeset patch > # User Paul Morelle > # Date 1510497286 -3600 > # Sun Nov 12 15:34:46 2017 +0100 > # Node ID 8bcccbbeafba2bc80ed9e427945e11a4728802e8 > # Parent

Re: [PATCH 1 of 2] lfs: correct the directory list value returned by lfsvfs.walk()

2017-12-13 Thread Yuya Nishihara
On Wed, 13 Dec 2017 00:33:02 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1513128158 18000 > # Tue Dec 12 20:22:38 2017 -0500 > # Node ID 380a4fb92c06e6725ec3027661ecf6f6d9e6cd1d > # Parent

Re: That pesky windows run-tests failure on the buildbot

2017-12-13 Thread Yuya Nishihara
On Tue, 12 Dec 2017 18:13:24 -0500, Matt Harbison wrote: > > On Dec 12, 2017, at 5:57 PM, Augie Fackler wrote: > > Finally, some useful output: > > > > + --- $TESTTMP/anothertests/test-runtestdir.t > > + +++ $TESTTMP/anothertests/test-runtestdir.t.err > > + @@ -10,6 +10,7 @@

D1426: logtoprocess: add the possibility to not start a shell

2017-12-13 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. Sorry, I'm not sure what the context is here. Is this all to resolve %FOO% type variables? I don't know of any library to do this either. Earlier this year I tried fixing the logtoprocess test, which was leaving out chunks of output on Windows. The only

D1682: unamend: allow unamending if allowunstable is set

2017-12-13 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I don't see why unamend should be disallowed when allowunstable is set. By switching to rewriteutil.precheck() we fix that and get more consistent error

Re: [PATCH] lfs: add an experimental config to masquerade as git for the blob transfer

2017-12-13 Thread Augie Fackler
> On Dec 13, 2017, at 6:20 PM, Matt Harbison wrote: > > > On Dec 13, 2017, at 9:48 AM, Augie Fackler > wrote: > >> >> I don't either. Do whichever of the versions that mentions hg that makes you >> happier? >> >> (I think

[PATCH V2] lfs: add an experimental config to masquerade as git for the blob transfer

2017-12-13 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1513109762 18000 # Tue Dec 12 15:16:02 2017 -0500 # Node ID a8d7f9c5012763e87460f90a8f06fee9d043ad79 # Parent 4937db58b663faa6893c51a41cec28114a165dd0 lfs: add an experimental config to masquerade as git for the blob

Re: [PATCH] lfs: add an experimental config to masquerade as git for the blob transfer

2017-12-13 Thread Matt Harbison
> On Dec 13, 2017, at 9:48 AM, Augie Fackler wrote: > > >> On Dec 13, 2017, at 09:47, Matt Harbison wrote: >> >> >> >>> On Dec 12, 2017, at 6:10 PM, Matt Harbison wrote: >>> >>> On Dec 12, 2017, at 5:48 PM, Augie

Re: That pesky windows run-tests failure on the buildbot

2017-12-13 Thread Matt Harbison
On Wed, Dec 13, 2017 at 9:31 AM, Augie Fackler wrote: > > > On Dec 13, 2017, at 08:14, Feld Boris wrote: > > > > On Wed, 2017-12-13 at 21:29 +0900, Yuya Nishihara wrote: > >> On Tue, 12 Dec 2017 18:13:24 -0500, Matt Harbison wrote: > On Dec 12,

D1681: rebase: add ui.log calls for whether IMM used, whether rebasing WCP

2017-12-13 Thread phillco (Phil Cohen)
phillco created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1681 AFFECTED FILES hgext/rebase.py CHANGE DETAILS diff --git a/hgext/rebase.py b/hgext/rebase.py

Re: [PATCH] lfs: add an experimental config to masquerade as git for the blob transfer

2017-12-13 Thread Matt Harbison
> On Dec 12, 2017, at 6:10 PM, Matt Harbison wrote: > > >> On Dec 12, 2017, at 5:48 PM, Augie Fackler wrote: >> >> >>> On Dec 12, 2017, at 17:32, Matt Harbison wrote: >>> >>> diff --git a/hgext/lfs/blobstore.py

Re: [PATCH 3 of 3] run-tests: accept '\' vs '/' path differences without '(glob)'

2017-12-13 Thread Martin von Zweigbergk via Mercurial-devel
I think the problem is in this line from the test (that you changed): $ echo " saved backup bundle to \$TESTTMP\foo.hg" >> test-failure.t The '\' there probably just needs to be escaped. It seems like at least dash and tcsh otherwise interpret it (but bash treats it literally). Proof: $ dash

D1679: rebase: fix for hgsubversion

2017-12-13 Thread phillco (Phil Cohen)
phillco added a comment. A better way might just be to use `None` for `self.wtcx` when rebasing on disk, which will cause fresh wctxs to be used every time and feel less icky. We could use `sel.inmemory` instead of `self.wctx.isinmemory()`. REPOSITORY rHG Mercurial REVISION DETAIL

D1658: memfilectx: make changectx argument mandatory in constructor (API)

2017-12-13 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG79392b35e947: memfilectx: make changectx argument mandatory in constructor (API) (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[Bug 5756] New: Allow closing arbitrary head revision

2017-12-13 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5756 Bug ID: 5756 Summary: Allow closing arbitrary head revision Product: Mercurial Version: unspecified Hardware: PC OS: Linux Status: UNCONFIRMED Severity: