D1621: transaction: encodes tuples in changes['phases'] as 4 bit ints

quark resigned from this revision. quark added a comment. When thinking about it again, I believe providing a way to disable `tr.chanages['phases']` is a better way to solve this issue. If we cannot disable that automatically from what hooks are used, we can still provide a config option to

Re: [PATCH v4] outgoing: respect ":pushurl" paths (issue5365)

> On Dec 15, 2017, at 11:22, Hollis Blanchard > wrote: > > # HG changeset patch > # User Hollis Blanchard > # Date 1513292635 28800 > # Thu Dec 14 15:03:55 2017 -0800 > # Node ID ad9e8305ba268522808a3a0ee415b47e5b9d7874 > # Parent

Re: [PATCH 2 of 2 V3] lfs: add an experimental config to override User-Agent for the blob transfer

On Thu, Dec 14, 2017 at 01:53:49PM -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1513109762 18000 > # Tue Dec 12 15:16:02 2017 -0500 > # Node ID a2ae07e57a0c91274018299afb250f0b921e4eb4 > # Parent

Re: [PATCH] check-code: remove unused variable 'winglobmsg'

On Thu, Dec 14, 2017 at 10:49:33PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1513258006 -32400 > # Thu Dec 14 22:26:46 2017 +0900 > # Node ID 5d3302425a6e4f4bd9e4af7877f58090daece3f0 > # Parent

Re: [PATCH 2 of 2] phases: initialize number of loaded revisions to 0

On Thu, Dec 14, 2017 at 10:49:50PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1513258630 -32400 > # Thu Dec 14 22:37:10 2017 +0900 > # Node ID a1744bbbec20259e7d2fed8733fd07031abbeb43 > # Parent

Re: [PATCH 2 of 2] help: deprecate ui.slash in favor of slashpath template filter (issue5572)

On Wed, Dec 13, 2017 at 12:03:38AM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1508574434 -32400 > # Sat Oct 21 17:27:14 2017 +0900 > # Node ID 740dce20be8f125bd7a55aad849932e1c40820a9 > # Parent

Re: [PATCH STABLE] debugssl: convert port number to int (issue5757)

On Thu, Dec 14, 2017 at 10:21:38PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1513256866 -32400 > # Thu Dec 14 22:07:46 2017 +0900 > # Branch stable > # Node ID 88572b7e50fd5f0e86329943795f6a3e38a2ec31 > # Parent

D1678: revset: pass pre-optimized tree in revset.matchany()

yuja added a comment. > Since we are calling them at each command level, it will be better to call unhidehashlikerevs() in `scmutil.revrange|revsingle`. I thought about that, but `scmutil.rev*()` would have to return new filtered `repo` object, which didn't seem nice. And mutating a

D1694: debugcommands: replace opts.get('foo') by opts['foo']

yuja added a comment. Queued the first three patches, but I'm not certain about this. Sometimes we do the reverse change for ease of calling command function as a plain function. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1694 To: martinvonz,

D1679: rebase: fix for hgsubversion

yuja added a comment. In https://phab.mercurial-scm.org/D1679#28814, @phillco wrote: > @yuja is that just because of the `_manifest` property cache, or are there others as well? Others, too. workingctx._parents() for example. REPOSITORY rHG Mercurial REVISION DETAIL

D1701: logtoprocess: add the possibility to not popup a console

yuja added a comment. > but could have other side-effects so it kept under a config knob. My two cents, `experimental.*` might be better if the config knob exists as a workaround for an unknown bug. INLINE COMMENTS > logtoprocess.py:66 > +if createconsole: > +

D1698: copies: group wdir-handling in one place

yuja added a comment. Nice. Queued, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1698 To: martinvonz, #hg-reviewers, yuja Cc: mercurial-devel ___ Mercurial-devel mailing list

D1693: debugdiscovery: drop reference to non-existent --remote-head option

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfed2c040764e: debugdiscovery: drop reference to non-existent --remote-head option (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1697: copies: extract method for getting non-wdir forward copies

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8801cdcea01f: copies: extract method for getting non-wdir forward copies (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1695: copies: always respect matcher arg to _forwardcopies()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7ddc1e96d9b0: copies: always respect matcher arg to _forwardcopies() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1696: copies: consistently use """ for docstrings

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9cf37d111acb: copies: consistently use for docstrings (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1696?vs=4445=4477

D1691: debugdiscovery: drop reference to invalid --branch option

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2105bdd9462a: debugdiscovery: drop reference to invalid --branch option (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1699: tests: avoid echo with backslash escapes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG417fa23017f9: tests: avoid echo with backslash escapes (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1699?vs=4465=4472

D1692: debugdiscovery: drop reference to non-existent --serverlog option

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc73d23cbb129: debugdiscovery: drop reference to non-existent --serverlog option (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1698: copies: group wdir-handling in one place

This revision was automatically updated to reflect the committed changes. Closed by commit rHG143f09cfc80f: copies: group wdir-handling in one place (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1698?vs=4447=4479

D1703: logtoprocess: connect all fds to /dev/null to avoid bad interaction with pager

yuja added inline comments. INLINE COMMENTS > logtoprocess.py:94 > +# and pager will wait for scripts to end if we don't do that > +nullrfd = open(os.devnull, 'r') > +nullwfd = open(os.devnull, 'w') Better to close these file objects in the parent

[PATCH 1 of 2 PoC] hgweb: display fate of obsolete changesets

# HG changeset patch # User Anton Shestakov # Date 1511255021 -28800 # Tue Nov 21 17:03:41 2017 +0800 # Node ID 3764b68ff62bb5144f814f17ffe6465bd915e51b # Parent a51541681b8d44420d41e177d38a5e0c7d6deb49 # EXP-Topic hgweb-more-info hgweb: display fate of obsolete

[PATCH 2 of 2 PoC] hgweb: link to successors of obsoleted changesets (PoC)

# HG changeset patch # User Anton Shestakov # Date 1513346027 -28800 # Fri Dec 15 21:53:47 2017 +0800 # Node ID 4273260ac0d6e9bcb293607c7bdc16d0d246e6e9 # Parent 3764b68ff62bb5144f814f17ffe6465bd915e51b # EXP-Topic hgweb-more-info hgweb: link to successors of obsoleted

D1427: logtoprocess: add a test to show pager and ltp bad interaction

yuja added inline comments. INLINE COMMENTS > lothiraldan wrote in test-logtoprocess.t:33 > I tried making the file path unique for each call (by adding `\$(date +%s)`) > but it doesn't seems to change anything in the stability unfortunately :( Can't we just append to the log file and sort the

Re: [PATCH] hgweb: stop using HTML comments in

On Fri, 15 Dec 2017 14:03:28 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1513311358 -28800 > # Fri Dec 15 12:15:58 2017 +0800 > # Node ID dc231e0cdccd7aa632b9787bcfbb216cb7bfb39b > # Parent

Re: [PATCH v3] outgoing: respect ":pushurl" paths (issue5365)

On Thu, 14 Dec 2017 16:23:24 -0800, Hollis Blanchard wrote: > # HG changeset patch > # User Hollis Blanchard > # Date 1513292635 28800 > # Thu Dec 14 15:03:55 2017 -0800 > # Node ID a71c6d5ea84933324e0c516ea2e4967e06616c31 > # Parent

D1702: logtoprocess: add a test to show pager and ltp bad interaction

yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. > XXX-REVIEW: I tried making the test file compatible with chg but it seems > flaky. The output is different when running only this test without parallelism > (rt

D1703: logtoprocess: connect all fds to /dev/null to avoid bad interaction with pager

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We detected that pager is waiting for log-to-process script to finish, which is annoying when adding a script on commandfinish that does an HTTP push.

D1702: logtoprocess: add a test to show pager and ltp bad interaction

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The next changeset will fix the bad interaction between the pager and log-to- process. Add a test first to make the next changeset easier to understand.

D1427: logtoprocess: add a test to show pager and ltp bad interaction

lothiraldan added inline comments. INLINE COMMENTS > yuja wrote in test-logtoprocess.t:33 > This file may be overwritten asynchronously by more than one > logging processes. That's probably why the test result is unstable > especially with chg. I tried making the file path unique for each call

D1426: logtoprocess: add the possibility to not start a shell

lothiraldan added a comment. I've resent as https://phab.mercurial-scm.org/D1700 because I couldn't get phabsend to reproduce my linear updated stack on phabricator :( REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1426 To: lothiraldan, #hg-reviewers, mbthomas

D1701: logtoprocess: add the possibility to not popup a console

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Starting a subprocess on Windows with `DETACHED_PROCESS | CREATE_NEW_PROCESS_GROUP` as startup info means starting a console GUI window in almost all cases.

D1700: logtoprocess: pass ui in runshellcommand

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We are gonna read a configuration specific to Windows, instead of adding a useless arguments for runshellcommand on linux, pass the ui object to read it

D1428: logtoprocess: connect all fds to /dev/null to avoid bad interaction with pager

lothiraldan updated this revision to Diff 4469. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1428?vs=3917=4469 REVISION DETAIL https://phab.mercurial-scm.org/D1428 AFFECTED FILES hgext/logtoprocess.py tests/test-logtoprocess.t CHANGE DETAILS

Re: [PATCH v3] outgoing: respect ":pushurl" paths (issue5365)

On 12/15/2017 05:15 AM, Yuya Nishihara wrote: On Thu, 14 Dec 2017 16:23:24 -0800, Hollis Blanchard wrote: # HG changeset patch # User Hollis Blanchard # Date 1513292635 28800 # Thu Dec 14 15:03:55 2017 -0800 # Node ID a71c6d5ea84933324e0c516ea2e4967e06616c31 #

D1698: copies: group wdir-handling in one place

krbullock added inline comments. INLINE COMMENTS > copies.py:206 > +return _chain(a, b, cm, _dirstatecopies(b, match)) > +else: > +return _committedforwardcopies(a, b, match) Post-queue nitpick: unnecessary `else:`. REPOSITORY rHG Mercurial REVISION DETAIL

[PATCH v4] outgoing: respect ":pushurl" paths (issue5365)

# HG changeset patch # User Hollis Blanchard # Date 1513292635 28800 # Thu Dec 14 15:03:55 2017 -0800 # Node ID ad9e8305ba268522808a3a0ee415b47e5b9d7874 # Parent 4937db58b663faa6893c51a41cec28114a165dd0 outgoing: respect ":pushurl" paths (issue5365) Make 'hg

D1691: debugdiscovery: drop reference to invalid --branch option

martinvonz added inline comments. INLINE COMMENTS > krbullock wrote in debugcommands.py:747 > Drop `[-b BRANCH]` from the usage string above too? Sure, will send a separate patch REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1691 To: martinvonz, #hg-reviewers,

[Bug 5759] New: diff.noprefix disables --stat output

https://bz.mercurial-scm.org/show_bug.cgi?id=5759 Bug ID: 5759 Summary: diff.noprefix disables --stat output Product: Mercurial Version: 4.4.2 Hardware: PC OS: Mac OS Status: UNCONFIRMED Severity: feature

D1691: debugdiscovery: drop reference to invalid --branch option

krbullock added inline comments. INLINE COMMENTS > debugcommands.py:747 > opts = pycompat.byteskwargs(opts) > -remoteurl, branches = hg.parseurl(ui.expandpath(remoteurl), > - opts.get('branch')) > +remoteurl, branches =

D1698: copies: group wdir-handling in one place

martinvonz added inline comments. INLINE COMMENTS > krbullock wrote in copies.py:206 > Post-queue nitpick: unnecessary `else:`. Feel free to update REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1698 To: martinvonz, #hg-reviewers, yuja Cc: krbullock,

D1706: debugdiscovery: correct and clean up command synopsis

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This does a few things: - Changes "-r" to "--rev", since "-r" is not a valid short form - Removes non-existent "-l" and "-b" options - Removes "..."

D1681: rebase: add ui.log calls for whether IMM used, whether rebasing WCP

This revision was automatically updated to reflect the committed changes. Closed by commit rHG464b3e5e3eec: rebase: add ui.log calls for whether IMM used, whether rebasing WCP (authored by phillco, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1682: unamend: allow unamending if allowunstable is set

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc1c55291e6ff: unamend: allow unamending if allowunstable is set (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1706: debugdiscovery: correct and clean up command synopsis

This revision was automatically updated to reflect the committed changes. Closed by commit rHG702e6d2642e7: debugdiscovery: correct and clean up command synopsis (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

mercurial@35415: 4 new changesets

4 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/b1959391a088 changeset: 35412:b1959391a088 user:Yuya Nishihara date:Sun Oct 01 12:21:50 2017 +0100 summary: extdata: abort if external command exits with non-zero status (BC)

mercurial@35422: 7 new changesets

7 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/417fa23017f9 changeset: 35416:417fa23017f9 user:Martin von Zweigbergk date:Thu Dec 14 22:30:03 2017 -0800 summary: tests: avoid echo with backslash escapes

Re: D1698: copies: group wdir-handling in one place

> On Dec 15, 2017, at 10:41, martinvonz (Martin von Zweigbergk) > wrote: > > martinvonz added inline comments. > > INLINE COMMENTS > >> krbullock wrote in copies.py:206 >> Post-queue nitpick: unnecessary `else:`. > > Feel free to update Fixed in-flight,

D1568: lfs: using workers in lfs prefetch

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2b7c0cba308f: lfs: using workers in lfs prefetch (authored by wlis, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1568?vs=4374=4489 REVISION

D1460: workers: add config to enable/diable workers

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9b7ee7b78856: workers: add config to enable/diable workers (authored by wlis, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1460?vs=4023=4487

D1458: workers: implemented worker on windows

This revision was automatically updated to reflect the committed changes. Closed by commit rHG02b36e860e0b: workers: implemented worker on windows (authored by wlis, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1458?vs=3665=4485

D1459: workers: handling exceptions in windows workers

This revision was automatically updated to reflect the committed changes. Closed by commit rHG71427ff1dff8: workers: handling exceptions in windows workers (authored by wlis, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1459?vs=3666=4486

D1457: workers: don't use backgroundfilecloser in threads

This revision was automatically updated to reflect the committed changes. Closed by commit rHG60f2a215faa7: workers: dont use backgroundfilecloser in threads (authored by wlis, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1564: worker: make windows workers daemons

This revision was automatically updated to reflect the committed changes. Closed by commit rHG487e7e6e89a0: worker: make windows workers daemons (authored by wlis, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1564?vs=4024=4488 REVISION

D1683: sshpeer: allow for additional environment passing to ssh exe

This revision was automatically updated to reflect the committed changes. Closed by commit rHG47921dafb44b: sshpeer: allow for additional environment passing to ssh exe (authored by ikostia, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1683: sshpeer: allow for additional environment passing to ssh exe

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Ugh. But clearly needed. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D1683 To: ikostia, #hg-reviewers, mbthomas, durin42 Cc: durin42,

D1710: tests: test-pathconflicts-merge.t requires symlinks

krbullock accepted this revision. krbullock added a comment. This revision is now accepted and ready to land. LGTM, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1710 To: durin42, #hg-reviewers, krbullock Cc: krbullock, mercurial-devel

D1710: tests: test-pathconflicts-merge.t requires symlinks

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Once we're ready to turn this functionality on more widely, we might want to write a symlink-free version of the test that can run on Windows, but for now we'll

D1710: tests: test-pathconflicts-merge.t requires symlinks

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf7de3353e59d: tests: test-pathconflicts-merge.t requires symlinks (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE