D1676: revset: take out logic generating matcher for empty spec in it's own fn

pulkit abandoned this revision. pulkit added a comment. Not required anymore. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1676 To: pulkit, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list

D1677: revset: extract the logic to build the tree in it's own function

pulkit abandoned this revision. pulkit added a comment. Not required anymore. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1677 To: pulkit, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list

D1732: revsetlang: add utility function to return hash like symbols from the tree

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Functionalities like unhiding changesets whose rev/hash is passed by the user required the knowledge of rev/hashes in the user provided specs. This patch adds

D1735: commands: use the new API to access hidden changesets in various commands

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In previous patches, we have added an internal API to unhide hidden changesets. This patch makes the following command use that api in nowarn mode i.e. there

D1734: repoview: add a new filtername for accessing hidden commits

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch adds a new filter 'visible-hidden' for repository and will be used to return a repo object with user passed revisions unhidden. Unlike the

[Bug 5760] New: hg clone http://orgmode.org/org-mode.git gives error

https://bz.mercurial-scm.org/show_bug.cgi?id=5760 Bug ID: 5760 Summary: hg clone http://orgmode.org/org-mode.git gives error Product: Mercurial Version: earlier Hardware: PC OS: Linux Status: UNCONFIRMED

mercurial@35453: 3 new changesets

3 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/d624c8558c61 changeset: 35451:d624c8558c61 user:Augie Fackler date:Mon Dec 18 13:15:10 2017 -0500 summary: tests: update expected output of svn encoding test

D1583: repoview: consider visibilityexceptions while considering filterrevs

pulkit abandoned this revision. pulkit added a comment. This series is superseded by https://phab.mercurial-scm.org/D1730 - https://phab.mercurial-scm.org/D1735. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1583 To: pulkit, #hg-reviewers Cc: mercurial-devel

D1492: repoview: take out the logic of computehidden to a new function

pulkit abandoned this revision. pulkit added a comment. This series is superseded by https://phab.mercurial-scm.org/D1730 - https://phab.mercurial-scm.org/D1735. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1492 To: pulkit, #hg-reviewers Cc: mercurial-devel

D1731: repoview: introduce function to add visibility exceptions

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We need to call self.invalidatevolatilesets() to clear filteredrevcache to make sure next time visibility exceptions are taken in consideration while computing

D1730: repoview: store visibility exceptions for the filter in filtertable

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Earlier, filtertable contains the filtername and the corresponding function to calculate filtered set for that filter. This patch make filtertable also store the

D1733: scmutil: add utility fn to return repo object with user passed revs unhidden

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There has been a need for accessing hidden changesets by default without passing --hidden. This is currently done using the directaccess extension but is bit

D1678: revset: pass pre-optimized tree in revset.matchany()

pulkit abandoned this revision. pulkit added a comment. In https://phab.mercurial-scm.org/D1678#29063, @yuja wrote: > > Since we are calling them at each command level, it will be better to call unhidehashlikerevs() in `scmutil.revrange|revsingle`. > > I thought about that, but

D1288: dispatch: filter the repository depending on func.cmdtype

pulkit abandoned this revision. pulkit added a comment. Moved the logic to filter repository at command level. This is not required anymore. This series is superseded by https://phab.mercurial-scm.org/D1730 - https://phab.mercurial-scm.org/D1735. REPOSITORY rHG Mercurial REVISION

D1144: directaccess: add tests for read only-commands

pulkit abandoned this revision. pulkit added a comment. The current series is superseded by https://phab.mercurial-scm.org/D1730 - https://phab.mercurial-scm.org/D1735. That one has better implementation of the idea and is a result of a lot of rounds of reviews by Yuya and Jun. REPOSITORY

D1287: repoview: add two new filternames to be used for accessing hidden commits

pulkit abandoned this revision. pulkit added a comment. This series is superseded by https://phab.mercurial-scm.org/D1730 - https://phab.mercurial-scm.org/D1735. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1287 To: pulkit, #hg-reviewers Cc: mercurial-devel

Problems with an own patch against Mercurial Queues

Greetings, for quite some time I have applied the following little patch to Mercur- ial, because I think a message containing the word "error" is in fact an error message and should thus go to standard error: $ cat .hg/patches/MqMessage | grep -v '^#" Redirect error message from stdout to

D1734: repoview: add a new filtername for accessing hidden commits

yuja added a comment. This should come before https://phab.mercurial-scm.org/D1733? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1734 To: pulkit, #hg-reviewers Cc: yuja, mercurial-devel ___ Mercurial-devel mailing

D1735: commands: use the new API to access hidden changesets in various commands

yuja added inline comments. INLINE COMMENTS > commands.py:1283 > +rev = opts.get('rev') > +repo = scmutil.unhidehashlikerevs(repo, [rev], 'nowarn') > +ctx = scmutil.revsingle(repo, rev) Maybe needs `if rev:`? Passing revspec=[''] seems not right. REPOSITORY rHG Mercurial

Re: [PATCH] hgweb: make different kinds of commits look differently on /graph (RFC)

On Tue, 19 Dec 2017 21:52:15 +0800 Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1513687285 -28800 > # Tue Dec 19 20:41:25 2017 +0800 > # Node ID c7259f4340b50c8b1863ac9a1379ab8412b27b87 > # Parent

D1730: repoview: store visibility exceptions for the filter in filtertable

yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > repoview.py:145 > # from scratch (very slow). > -filtertable = {'visible': computehidden, > - 'served': computeunserved, > -

D1732: revsetlang: add utility function to return hash like symbols from the tree

yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > revsetlang.py:665 > + > +hashre = util.re.compile('[0-9a-fA-F]{1,40}') > + Nit: `_hashre` to mark it a private. > revsetlang.py:674 > + > +for example for

[PATCH] hgweb: make different kinds of commits look differently on /graph (RFC)

# HG changeset patch # User Anton Shestakov # Date 1513687285 -28800 # Tue Dec 19 20:41:25 2017 +0800 # Node ID c7259f4340b50c8b1863ac9a1379ab8412b27b87 # Parent e28dedf4ff4368820bbb085c668c3e6ea2088842 hgweb: make different kinds of commits look differently on /graph

D1733: scmutil: add utility fn to return repo object with user passed revs unhidden

yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. Other than that, this one looks good. INLINE COMMENTS > scmutil.py:1345 > + > +repo = repo.filtered('visible-hidden') > +repo.addvisibilityexceptions(revs) If `visible-` is

D1591: visibility: improve the message when accessing filtered obsolete rev

pulkit added a comment. Looks good to me but you forgot to update the commit message. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1591 To: lothiraldan, #hg-reviewers, durin42, pulkit Cc: pulkit, durin42, mercurial-devel

D1721: debug: customizable timestamp when printing ui.debug text

spectral added a comment. Someone pointed me at https://bitbucket.org/octobus/mercurial-devel/commits/668806cb43a0 and mentioned discussions on the devel mailing list that I haven't tracked down yet. Theirs is more complete and probably better than mine, so it would be nice to unify them

[Bug 5762] New: Illegal byte sequence error during clone or update

https://bz.mercurial-scm.org/show_bug.cgi?id=5762 Bug ID: 5762 Summary: Illegal byte sequence error during clone or update Product: Mercurial Version: 4.4.2 Hardware: Macintosh OS: Mac OS Status: UNCONFIRMED

D1082: split: new extension to split changesets

quark added inline comments. INLINE COMMENTS > martinvonz wrote in split.py:90 > s/ctx/rev/ seems a little clearer (I realize that ctx has a __int__ method, > but I didn't know that until I read this) Good advice. This is probably copy-pasted from old code. > martinvonz wrote in split.py:95 >

D1082: split: new extension to split changesets

This revision was automatically updated to reflect the committed changes. Closed by commit rHG02ea370c2baa: split: new extension to split changesets (authored by quark, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1082?vs=4555=4556

D1082: split: new extension to split changesets

martinvonz added inline comments. INLINE COMMENTS > split.py:90 > + > +descendants = list(repo.revs('(%d::) - (%d)', ctx, ctx)) > +alloworphaned = obsolete.isenabled(repo, obsolete.allowunstableopt) s/ctx/rev/ seems a little clearer (I realize that ctx has a __int__ method, but

D1721: debug: customizable timestamp when printing ui.debug text

spectral added a comment. I'm not going to recommend to users to "see if you can reproduce the slowness issues while running with `PYTHONUNBUFFERED=1 /usr/bin/hg --debug | ruby -e'start = Time.now.to_f' -e'STDIN.each_line do |l|' -e" puts \"#{'%.3f' % (Time.now.to_f - start)} #{l}\""

D1721: debug: customizable timestamp when printing ui.debug text

spectral added a comment. https://www.mercurial-scm.org/pipermail/mercurial-devel/2017-April/096617.html is the mailing list thread. Sounds like core is generally negative on the idea, which is disappointing, but OK.I can drop it easily :) REPOSITORY rHG Mercurial REVISION DETAIL

Re: [PATCH] sshpeer: move docstring to top

> On Dec 19, 2017, at 09:37, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1513599353 -32400 > # Mon Dec 18 21:15:53 2017 +0900 > # Node ID c836f3fd99ec97b248434e1523c73d77066c1d43 > # Parent

Re: [PATCH] log: make "slowpath" condition slightly more readable

> On Dec 19, 2017, at 09:37, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1513687299 -32400 > # Tue Dec 19 21:41:39 2017 +0900 > # Node ID 2ce83446b12b43dfeddf1c0aadb5c8753047797a > # Parent