Re: [PATCH 1 of 2] templater: add brief doc about internal data types

2018-03-20 Thread Pulkit Goyal
On Mon, Mar 19, 2018 at 7:16 PM, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1521464102 -32400 > # Mon Mar 19 21:55:02 2018 +0900 > # Node ID cb8ab2dddf79e4ff203e22b4130ceca5b88bb14b > # Parent

D2666: repair: rename _backup to backupbundle

2018-03-20 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG17692fefc8f2: repair: rename _backup to backupbundle (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2666?vs=6636=7160

D2897: fix: new extension for automatically modifying file contents

2018-03-20 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Haven't reviewed the patch but I think `fix` is too generic for this use case. What about `format`? Sorry for not having this idea when we had couple of discussion on it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2897 To: hooper,

Re: [PATCH] obsolete: add a note that explains creating aliases for marker flags

2018-03-20 Thread Feld Boris
LGTM On 20/03/2018 11:15, Anton Shestakov wrote: # HG changeset patch # User Anton Shestakov # Date 1521526325 -28800 # Tue Mar 20 14:12:05 2018 +0800 # Node ID 6ee52d3b6bd4b86a68799cc969035cd0fd77ffe5 # Parent e349ad5cbb7195607a300439a12a5316795125f8 obsolete: add a

D2807: remotenames: add functionality to hoist remotebookmarks

2018-03-20 Thread pulkit (Pulkit Goyal)
pulkit added a comment. A gentle reminder to get this series reviewed. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2807 To: pulkit, #hg-reviewers, durin42 Cc: durin42, mercurial-devel ___ Mercurial-devel mailing

D2750: thirdparty: start vendoring cbor python library

2018-03-20 Thread pulkit (Pulkit Goyal)
pulkit added a comment. A gentle reminder to get this series reviewed. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2750 To: pulkit, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list

Re: [PATCH] obsolete: add a note that explains creating aliases for marker flags

2018-03-20 Thread Pulkit Goyal
On Tue, Mar 20, 2018 at 3:45 PM, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1521526325 -28800 > # Tue Mar 20 14:12:05 2018 +0800 > # Node ID 6ee52d3b6bd4b86a68799cc969035cd0fd77ffe5 > # Parent

[PATCH] hgweb: explain instabilities of unstable changesets (the rest of the themes)

2018-03-20 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1521526768 -28800 # Tue Mar 20 14:19:28 2018 +0800 # Node ID 81060ada33729a2b4f250f72416a3efab2c5f398 # Parent e349ad5cbb7195607a300439a12a5316795125f8 hgweb: explain instabilities of unstable changesets (the rest of the

[PATCH] obsolete: add a note that explains creating aliases for marker flags

2018-03-20 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1521526325 -28800 # Tue Mar 20 14:12:05 2018 +0800 # Node ID 6ee52d3b6bd4b86a68799cc969035cd0fd77ffe5 # Parent e349ad5cbb7195607a300439a12a5316795125f8 obsolete: add a note that explains creating aliases for marker flags

D2842: util: don't log low-level I/O calls for HTTP peer

2018-03-20 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 7161. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2842?vs=7008=7161 REVISION DETAIL https://phab.mercurial-scm.org/D2842 AFFECTED FILES mercurial/debugcommands.py mercurial/util.py

mercurial@36999: 18 new changesets

2018-03-20 Thread Mercurial Commits
18 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/255f635c3204 changeset: 36982:255f635c3204 parent: 36978:c479692690ef user:Yuya Nishihara date:Sun Mar 11 21:05:29 2018 +0900 summary: templater: convert resources to a table of

D2897: fix: new extension for automatically modifying file contents

2018-03-20 Thread hooper (Danny Hooper)
hooper updated this revision to Diff 7165. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2897?vs=7123=7165 REVISION DETAIL https://phab.mercurial-scm.org/D2897 AFFECTED FILES hgext/fix.py tests/test-doctest.py tests/test-fix-clang-format.t

D2907: wireproto: add streams to frame-based protocol

2018-03-20 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, the frame-based protocol was just a series of frames, with each frame associated with a request ID. In order to scale the protocol, we'll want

D2906: wireproto: start to associate frame generation with a stream

2018-03-20 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY An upcoming commit will introduce "streams" into the frame-based wire protocol. In preparation for this invasive change, we introduce a basic "stream" class

D2897: fix: new extension for automatically modifying file contents

2018-03-20 Thread hooper (Danny Hooper)
hooper added a comment. In https://phab.mercurial-scm.org/D2897#46656, @pulkit wrote: > Haven't reviewed the patch but I think `fix` is too generic for this use case. What about `format`? Sorry for not having this idea when we had couple of discussion on it. I will do a final

D2057: rust implementation of hg status

2018-03-20 Thread kevincox (Kevin Cox)
kevincox added a comment. I'm not a windows expert but it seems like the rust OsStr, Path and filesystem APIs should handle these conversions for you. I think the only place where you would need to do os-specific code is when doing serialization and serialization which I think should be

D2905: rebase: pass "inmemory" directly to _definedestmap()

2018-03-20 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We no longer reassign rbsrt.inmemory in _definedestmap(), so we don't need to pass the whole rebase runtime instance anymore, thus making it clear that it

Re: [PATCH] hgweb: explain instabilities of unstable changesets (the rest of the themes)

2018-03-20 Thread Yuya Nishihara
On Tue, 20 Mar 2018 18:16:25 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1521526768 -28800 > # Tue Mar 20 14:19:28 2018 +0800 > # Node ID 81060ada33729a2b4f250f72416a3efab2c5f398 > # Parent

Re: [PATCH 1 of 2] test-http-protocol: drop an extraneous glob for Windows

2018-03-20 Thread Yuya Nishihara
On Tue, 20 Mar 2018 21:24:27 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1521592417 14400 > # Tue Mar 20 20:33:37 2018 -0400 > # Node ID f2b5c2b7d2e53fe7a8d3891efc5ba50d4785b61c > # Parent

D2896: commands: use keyword arguments in update function

2018-03-20 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. Python 3? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2896 To: pulkit, #hg-reviewers, yuja Cc: yuja, mercurial-devel

[PATCH 2 of 2] test-merge-tools: stabilize for Windows

2018-03-20 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1521594629 14400 # Tue Mar 20 21:10:29 2018 -0400 # Node ID 6bc2f1b3bc9d3fb73ffe605f9d811bd75727434e # Parent f2b5c2b7d2e53fe7a8d3891efc5ba50d4785b61c test-merge-tools: stabilize for Windows See fe5c4b795999. diff

[PATCH 1 of 2] test-http-protocol: drop an extraneous glob for Windows

2018-03-20 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1521592417 14400 # Tue Mar 20 20:33:37 2018 -0400 # Node ID f2b5c2b7d2e53fe7a8d3891efc5ba50d4785b61c # Parent c83e2736c6deb7e1b6b5eccb6b943b2af7628858 test-http-protocol: drop an extraneous glob for Windows diff

D2905: rebase: pass "inmemory" directly to _definedestmap()

2018-03-20 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0782ac132a41: rebase: pass inmemory directly to _definedestmap() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH] added tls 1.3 support - done during IETF101 Hackathon

2018-03-20 Thread Yuya Nishihara
On Sun, 18 Mar 2018 12:04:18 +0400, Codarren Velvindron wrote: > # HG changeset patch > # User Codarren Velvindron > # Date 1521360069 -14400 > # Sun Mar 18 12:01:09 2018 +0400 > # Node ID a47713f3cc05fafceed9bc8086734ffed65d51a5 > # Parent

D2889: filemerge: make the 'local' path match the format that 'base' and 'other' use

2018-03-20 Thread yuja (Yuya Nishihara)
yuja added a comment. Can't apply. % hg up -C a4a95bd7 2 files updated, 0 files merged, 0 files removed, 0 files unresolved % hg pimp D2889 devel-warn: accessing unregistered config item: 'phabricator.batchsize' at: /home/yuya/work/hghacks/mercurial/mercurial/ui.py:624

D2883: revlogstore: create and implement an interface for repo files storage

2018-03-20 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. It's probably too early to worry about for the experimenting that you're doing, but at some point, maybe this should also allow yielding the full text in chunks? As it stands now, there are a couple places where LFS has to read in the full file, and one of

D2057: rust implementation of hg status

2018-03-20 Thread yuja (Yuya Nishihara)
yuja added a comment. > I think the only place where you would need to do os-specific code is when > doing serialization and serialization Yes, that will be feasible in strictly typed language like Rust. > which I think should be handled by

D2904: templatefuncs: add mailmap template function

2018-03-20 Thread sheehan (Connor Sheehan)
sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This commit adds a template function to support the .mailmap file in Mercurial repositories. The .mailmap file comes from git, and can be used to map new emails

D2903: utils: add isauthorwellformed function

2018-03-20 Thread sheehan (Connor Sheehan)
sheehan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Adds a function to determine if an author field is formatted correctly (ie "Contributor Name ") REPOSITORY rHG Mercurial REVISION

D2057: rust implementation of hg status

2018-03-20 Thread quark (Jun Wu)
quark added a comment. https://crates.io/crates/local-encoding seems to be the right choice. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2057 To: Ivzhh, #hg-reviewers, kevincox Cc: quark, yuja, glandium, krbullock, indygreg, durin42, kevincox,

D2396: stack: import Evolve stack test file

2018-03-20 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > test-stack.t:81 > + | > + o 3 foo draft c_d > + | What if this was @ in the hg repo and only commits 4 and 5 were my own, then I would not want it to be part of my stack. It feels like a definition of upstream would be very helpful.