D2945: state: add a magicheader to each state file

2018-03-28 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D2945#47831, @yuja wrote: > I think the magic has to vary depending on the current state file format. > The state file must be backward/forward compatible with the older/newer formats. > > If the current magic is `2\n` (and

D2926: narrow: use featuresetupfuncs

2018-03-28 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe2d386b8a38f: narrow: use featuresetupfuncs (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2926?vs=7218=7349 REVISION

[PATCH V4] remove: add dry-run functionality

2018-03-28 Thread Sushil khanchi
# HG changeset patch # User Sushil khanchi # Date 1521655571 -19800 # Wed Mar 21 23:36:11 2018 +0530 # Node ID 4d0b9cc7615ad6bbe505819534a93978d9533461 # Parent b6a4881cec1937a8d9cd2e9bbbdf5ca31cfa73dd remove: add dry-run functionality diff -r b6a4881cec19 -r

D2959: stringutil: add isauthorwellformed function

2018-03-28 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. Looks mostly good, but can you fix these nits? INLINE COMMENTS > stringutil.py:290 > + > +_correctauthorformat = remod.compile('^[^<]+\s\<[^<>]+@[^<>]+\>$') > +def

Re: [PATCH V2] lfs: respect narrowmatcher when testing to add 'lfs' requirement (issue5794)

2018-03-28 Thread Yuya Nishihara
On Tue, 27 Mar 2018 20:33:01 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1522117116 14400 > # Mon Mar 26 22:18:36 2018 -0400 > # Node ID f9c8f2bd9362baaeba828f8d6eb7559a748fcc3f > # Parent

D2945: state: add a magicheader to each state file

2018-03-28 Thread yuja (Yuya Nishihara)
yuja added a comment. > There are some old state files, which don't have a version header on top > of them like graftstate. I need suggestion on how to handle them. In that case, we would have to either do some heuristic (like histedit), or maintain old/new state files (like

[PATCH 2 of 2] py3: bytes/unicode dance on __doc__ of cmdalias

2018-03-28 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1522242407 -32400 # Wed Mar 28 22:06:47 2018 +0900 # Node ID ae01ece672206c33d8218df0e4b55104be075fd9 # Parent 34381b51be48dad3a7b53c663aa5f38e8f5913fa py3: bytes/unicode dance on __doc__ of cmdalias diff --git

[PATCH 1 of 2] alias: reject non-ascii characters in user help/doc strings

2018-03-28 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1522242285 -32400 # Wed Mar 28 22:04:45 2018 +0900 # Node ID 34381b51be48dad3a7b53c663aa5f38e8f5913fa # Parent 4d63f3bc1e1ad3bd145af95d6eab8104684686ca alias: reject non-ascii characters in user help/doc strings Since command

Re: [PATCH V4] remove: add dry-run functionality

2018-03-28 Thread Yuya Nishihara
On Wed, 28 Mar 2018 18:39:23 +0530, Sushil khanchi wrote: > # HG changeset patch > # User Sushil khanchi > # Date 1521655571 -19800 > # Wed Mar 21 23:36:11 2018 +0530 > # Node ID 4d0b9cc7615ad6bbe505819534a93978d9533461 > # Parent

D2591: state: import the file to write state files from evolve extension

2018-03-28 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > yuja wrote in state.py:55 > Nit: this seems too clever. I wouldn't expect `if state` issues a system call. I agree. Let's not implement `__nonzero__`. >

[Bug 5829] New: Google (& etc) can't search Bugzilla due to robots.txt

2018-03-28 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5829 Bug ID: 5829 Summary: Google (& etc) can't search Bugzilla due to robots.txt Product: Mercurial project Version: unspecified Hardware: All OS: All Status:

[PATCH V4] remove: add dry-run functionality

2018-03-28 Thread Sushil khanchi
# HG changeset patch # User Sushil khanchi # Date 1521655571 -19800 # Wed Mar 21 23:36:11 2018 +0530 # Node ID d4a3c5969df336e556463a1b0b49132dc907f536 # Parent b6a4881cec1937a8d9cd2e9bbbdf5ca31cfa73dd remove: add dry-run functionality diff -r b6a4881cec19 -r

D2932: setup: register zope.interface packages and compile C extension

2018-03-28 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 7351. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2932?vs=7245=7351 REVISION DETAIL https://phab.mercurial-scm.org/D2932 AFFECTED FILES contrib/import-checker.py setup.py CHANGE DETAILS diff --git

Re: [PATCH 1 of 2] alias: reject non-ascii characters in user help/doc strings

2018-03-28 Thread Pulkit Goyal
On Wed, Mar 28, 2018 at 6:48 PM, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1522242285 -32400 > # Wed Mar 28 22:04:45 2018 +0900 > # Node ID 34381b51be48dad3a7b53c663aa5f38e8f5913fa > # Parent

[PATCH 2 of 2] tests: conditionalize printed environment variable output in test-alias

2018-03-28 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1522291081 14400 # Wed Mar 28 22:38:01 2018 -0400 # Node ID 52a792d66f2f14dd75af06981dcfbb3678daf094 # Parent 7a6eccc3b43dd8f6090b23aa38b2f71d33f5bbdc tests: conditionalize printed environment variable output in

D2939: fsmonitor: layer on another hack in bser.c for os.stat() compat (issue5811)

2018-03-28 Thread indygreg (Gregory Szorc)
indygreg added a comment. I managed to debug this. `st[state.ST_MTIME]` will invoke `PyObject_GetItem`. Its implementation does this: m = o->ob_type->tp_as_mapping; if (m && m->mp_subscript) return m->mp_subscript(o, key); if (o->ob_type->tp_as_sequence) {

[PATCH 1 of 2] server: add an error feedback mechanism for when the daemon fails to launch

2018-03-28 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1522210269 14400 # Wed Mar 28 00:11:09 2018 -0400 # Node ID 7a6eccc3b43dd8f6090b23aa38b2f71d33f5bbdc # Parent 8bac14ce57781d2a45b6d036b3614b1a21917f0d server: add an error feedback mechanism for when the daemon fails

[Bug 5830] New: Record on a moved file ignores chunk selection

2018-03-28 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5830 Bug ID: 5830 Summary: Record on a moved file ignores chunk selection Product: Mercurial Version: 4.5 Hardware: All OS: All Status: UNCONFIRMED Severity:

D2961: locate: avoid using "rev" variable name for nodeid

2018-03-28 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Also, drop silly "ctx = repo[ctx.node()]". REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2961 AFFECTED FILES

D2962: tag: avoid using "r" variable name for nodeid

2018-03-28 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbb141aa54728: tag: avoid using r variable name for nodeid (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2961: locate: avoid using "rev" variable name for nodeid

2018-03-28 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGeb4a23382e18: locate: avoid using rev variable name for nodeid (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2963: debugsetparents: avoid using "r1/r2" variable names for nodeids

2018-03-28 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8bac14ce5778: debugsetparents: avoid using r1/r2 variable names for nodeids (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2948: wireproto: syntax for encoding CBOR into frames

2018-03-28 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 7352. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2948?vs=7327=7352 REVISION DETAIL https://phab.mercurial-scm.org/D2948 AFFECTED FILES mercurial/debugcommands.py mercurial/utils/stringutil.py

D2963: debugsetparents: avoid using "r1/r2" variable names for nodeids

2018-03-28 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2963 AFFECTED FILES mercurial/debugcommands.py CHANGE DETAILS diff --git

D2962: tag: avoid using "r" variable name for nodeid

2018-03-28 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2962 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git a/mercurial/commands.py

D2897: fix: new extension for automatically modifying file contents

2018-03-28 Thread pulkit (Pulkit Goyal)
pulkit added subscribers: indygreg, yuja, martinvonz, krbullock, durin42. pulkit added a comment. The code except of minor nits looks good to me. I will like others to chime in on whether we should rename the command and extension to `format` because `fix` is too generic. I will push it once

D2678: help: supporting both help and doc for aliases

2018-03-28 Thread rdamazio (Rodrigo Damazio Bovendorp)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6890b7e991a4: help: supporting both help and doc for aliases (authored by rdamazio, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2925: localrepo: move featuresetupfuncs out of localrepository class (API)

2018-03-28 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGecac0006b90e: localrepo: move featuresetupfuncs out of localrepository class (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2927: localrepo: make filterpats private (API)

2018-03-28 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdb90a5793103: localrepo: make filterpats private (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2927?vs=7219=7350

[Bug 5828] New: Config option to prevent amending with working directory with date change

2018-03-28 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5828 Bug ID: 5828 Summary: Config option to prevent amending with working directory with date change Product: Mercurial Version: 4.5 Hardware: PC OS: Linux