D3665: graph: improve graph output by using Unicode characters

2018-05-30 Thread johnstiles (John Stiles)
johnstiles added a comment. In https://phab.mercurial-scm.org/D3665#57675, @indygreg wrote: > FWIW, this isn't rendering nicely with PuTTY on Windows 10. The U+25EF ◯ glyph is being truncated on the right side. I'm also seeing empty squares for U+233E ⌾ and other code points. Using

D3665: graph: improve graph output by using Unicode characters

2018-05-30 Thread johnstiles (John Stiles)
johnstiles added a comment. In https://phab.mercurial-scm.org/D3665#57678, @indygreg wrote: > I installed Dejavu Sans Mono from https://dejavu-fonts.github.io/ and it works great! That's great to hear! How do you like it? It's a pretty simple extension but it definitely

D3675: fuzz: extract some common utilities and use modern C++ idioms

2018-05-30 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Alex Gaynor suggested we should probably copy the left and right sides of diffs to new blocks so we can detect over-reads in the diffing code, and I agree. Once

D3677: fuzz: add clean target

2018-05-30 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3677 AFFECTED FILES contrib/fuzz/Makefile CHANGE DETAILS diff --git a/contrib/fuzz/Makefile

D3676: fuzzutil: make it possible to use absl when C++17 isn't supported

2018-05-30 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3676 AFFECTED FILES contrib/fuzz/Makefile contrib/fuzz/fuzzutil.cc contrib/fuzz/fuzzutil.h CHANGE

D3674: tests: update fuzzer tests to include both fuzzers

2018-05-30 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3674 AFFECTED FILES tests/test-fuzz-targets.t CHANGE DETAILS diff --git a/tests/test-fuzz-targets.t

D3665: graph: improve graph output by using Unicode characters

2018-05-30 Thread indygreg (Gregory Szorc)
indygreg added a comment. I installed Dejavu Sans Mono from https://dejavu-fonts.github.io/ and it works great! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3665 To: johnstiles, #hg-reviewers Cc: indygreg, smf, yuja, mercurial-devel

D3665: graph: improve graph output by using Unicode characters

2018-05-30 Thread indygreg (Gregory Szorc)
indygreg added a comment. FWIW, this isn't rendering nicely with PuTTY on Windows 10. The U+25EF ◯ glyph is being truncated on the right side. I'm also seeing empty squares for U+233E ⌾ and other code points. Using Courier New as the terminal font. `LANG=en_US.UTF-8` and

D3671: advanceboundary: add dryrun parameter

2018-05-30 Thread pulkit (Pulkit Goyal)
pulkit requested changes to this revision. pulkit added a comment. This revision now requires changes to proceed. Thanks for breaking this up. I have some put comments which are mostly doubts, can you explain by replying to them why you did so? INLINE COMMENTS > phases.py:369 > > +

mercurial@38099: 59 new changesets

2018-05-30 Thread Mercurial Commits
59 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/242eb5132203 changeset: 38041:242eb5132203 parent: 38031:37ef6ee87488 user:hindlemail date:Wed May 16 14:11:41 2018 -0600 summary: filemerge: support specifying a python function to custom

Re: [PATCH 1 of 2] unionrepo: fill in uncompressed length of revlog entry

2018-05-30 Thread Gregory Szorc
On Fri, May 25, 2018 at 7:49 PM, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1527301911 -32400 > # Sat May 26 11:31:51 2018 +0900 > # Node ID 31143eaaf90624060f7bd894421daafa5226605c > # Parent 2ce1e9bdc7157948fa799888009cc4c20c113d8c > unionrepo: fill in

D3676: fuzzutil: make it possible to use absl when C++17 isn't supported

2018-05-30 Thread indygreg (Gregory Szorc)
indygreg added a comment. I'm assuming https://abseil.io/ is part of the standard environment in oss-fuzz. Otherwise, we may want to vendor it or provide a script to download it or something. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3676 To: durin42,

D3665: graph: improve graph output by using Unicode characters

2018-05-30 Thread indygreg (Gregory Szorc)
indygreg added a comment. I think this is a cool idea! I could nitpick some of the glyph choices (e.g. U+233E ⌾ is really small and harder to read than `@` and U+25CC ◌ looks like a circle and therefore the standard node type). But overall I like it! We //could// roll this functionality

D3676: fuzzutil: make it possible to use absl when C++17 isn't supported

2018-05-30 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG36d55f90e2a3: fuzzutil: make it possible to use absl when C++17 isnt supported (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3675: fuzz: extract some common utilities and use modern C++ idioms

2018-05-30 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfa0ddd5e8fff: fuzz: extract some common utilities and use modern C++ idioms (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3677: fuzz: add clean target

2018-05-30 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfbe239064064: fuzz: add clean target (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3677?vs=8934=8938 REVISION DETAIL

D3674: tests: update fuzzer tests to include both fuzzers

2018-05-30 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG24cc2969abae: tests: update fuzzer tests to include both fuzzers (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3676: fuzzutil: make it possible to use absl when C++17 isn't supported

2018-05-30 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D3676#57722, @indygreg wrote: > I'm assuming https://abseil.io/ is part of the standard environment in oss-fuzz. Otherwise, we may want to vendor it or provide a script to download it or something. Actually, it's not

D3557: commit: add new close-branch command

2018-05-30 Thread indygreg (Gregory Szorc)
indygreg added a comment. I'm -0.25 on this. But I don't think we should add an argument to `hg heads` or `hg branch` because I don't like a) overloading commands to have multiple meanings b) making commands read-write and read-only. I think commands should do one thing and do them

D3665: graph: improve graph output by using Unicode characters

2018-05-30 Thread johnstiles (John Stiles)
johnstiles added a comment. In https://phab.mercurial-scm.org/D3665#57735, @indygreg wrote: > I think this is a cool idea! I could nitpick some of the glyph choices (e.g. U+233E ⌾ is really small and harder to read than `@` and U+25CC ◌ looks like a circle and therefore the standard

D3665: graph: improve graph output by using Unicode characters

2018-05-30 Thread johnstiles (John Stiles)
johnstiles added a comment. I experimented some more in Linux and got some surprisingly different outcomes. Fallback rules definitely vary! Anyway, I think these glyphs are going to work the best across the widest variety of fonts. They are in the same character group so they should all be

D3665: graph: improve graph output by using Unicode characters

2018-05-30 Thread johnstiles (John Stiles)
johnstiles added a comment. I'm finding that on OS X, the following two glyphs get good results in almost every font, and great results in Menlo and DejaVu Sans Mono. I wish they popped a little more in Ubuntu Mono but they are still better than the current choices. I'll switch over to

D3671: advanceboundary: add dryrun parameter

2018-05-30 Thread khanchi97 (Sushil khanchi)
khanchi97 added inline comments. INLINE COMMENTS > pulkit wrote in phases.py:369 > why are we maintaining this rejected list? rejected list will contain those csets which will be rejected during advancing boundary and then return this list so that we can report for rejected csets during

D3665: graph: improve graph output by using Unicode characters

2018-05-30 Thread johnstiles (John Stiles)
johnstiles added a comment. A proper warning is now issued when the encoding is not UTF-8, or when East-Asian ambiguous characters will be rendered as wide characters. The tests have been updated to check these warnings. Yuya, I believe this should address everything we discussed. Let me

D3671: advanceboundary: add dryrun parameter

2018-05-30 Thread khanchi97 (Sushil khanchi)
khanchi97 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Added logic to find those csets whose phase will be changed (when running without --dryrun) while advancing boundary. And make it return rejected and changed

D3672: retractboundary: add dryrun parameter

2018-05-30 Thread khanchi97 (Sushil khanchi)
khanchi97 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Added the logic to find those csets whose phase will be changed without dry-run while retracting boundary and return those csets. REPOSITORY rHG Mercurial

Re: [PATCH] outgoing: pay attention to `default:pushurl` for bookmarks and subrepos

2018-05-30 Thread Yuya Nishihara
On Tue, 29 May 2018 20:35:42 +0900, Yuya Nishihara wrote: > On Tue, 29 May 2018 00:42:23 -0400, Matt Harbison wrote: > > # HG changeset patch > > # User Matt Harbison > > # Date 1527485794 14400 > > # Mon May 28 01:36:34 2018 -0400 > > # Node ID 8544cdf89153aa7c0ce5be9c4dfdc052b2bf5d60 > > #

Re: [PATCH] transaction-summary: show phase changes statistics in pull/unbundle

2018-05-30 Thread Yuya Nishihara
On Thu, 24 May 2018 15:48:01 +0200, Denis Laxalde wrote: > # HG changeset patch > # User Denis Laxalde > # Date 1527157190 -7200 > # Thu May 24 12:19:50 2018 +0200 > # Node ID 48bc12fc4aee84bffa539f9ced452e6c686a53e4 > # Parent 37ef6ee87488ac0095f8dedf75284f64d1d54455 > # Available At

D3665: graph: improve graph output by using Unicode characters

2018-05-30 Thread yuja (Yuya Nishihara)
yuja added a comment. > A proper warning is now issued when the encoding is not UTF-8, or when East-Asian ambiguous characters will be rendered as wide characters. > The tests have been updated to check these warnings. > Yuya, I believe this should address everything we discussed.

Re: D3665: graph: improve graph output by using Unicode characters

2018-05-30 Thread Yuya Nishihara
> A proper warning is now issued when the encoding is not UTF-8, or when > East-Asian ambiguous characters will be rendered as wide characters. > The tests have been updated to check these warnings. > Yuya, I believe this should address everything we discussed. Let me know if > you see a

D3673: grep: enables passing wdir as a revision in grep

2018-05-30 Thread sangeet259 (Sangeet Kumar Mishra)
sangeet259 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When you pass wdir() to the -r flag, it catches the WdirUnsupported error and fall back to and alternate path REPOSITORY rHG Mercurial REVISION DETAIL

[Bug 5903] New: allow to ignore binary files that don't have a file extension

2018-05-30 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5903 Bug ID: 5903 Summary: allow to ignore binary files that don't have a file extension Product: Mercurial Version: 3.7.3 Hardware: PC OS: Linux